-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] add authorization header to httpstep #170
Merged
dannymeijer
merged 35 commits into
main
from
162-feature-add-authorization_header-to-httpstep
Feb 26, 2025
Merged
[FEATURE] add authorization header to httpstep #170
dannymeijer
merged 35 commits into
main
from
162-feature-add-authorization_header-to-httpstep
Feb 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…larify exception handling
…nd improve test coverage. Restore to 'normal' python string behavior.
…safe and unsafe contexts + leave handling of __format__ to the super class in unsafe scenario
… context handling to Pydantic
…lication support in SecretStr and SecretBytes
…r for enhanced security
…d parameterization
…avoid duplications
…e logging in nested inheritance tests + improved test
…BaseModel for consistency; update related tests
…ct dependencies in pyproject.toml
…with requests_mock in HTTP tests for clarity
… contexts for SecretStr
…ddress Python 3.12 f-string behavior
…e-add-authorization_header-to-httpstep
… into 162-feature-add-authorization_header-to-httpstep
zarembat
suggested changes
Feb 26, 2025
zarembat
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat 😊
pariksheet
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to the
HttpStep
class and adds comprehensive unit tests. The changes to theHttpStep
class include:decode_sensitive_headers
method to decodeSecretStr
values in headers.get_headers
method to dump headers into JSON withoutSecretStr
masking.get
,post
,put
,delete
) to handle different HTTP methods.auth_header
field to handle authorization headers, replacing the previous implementation.The unit tests cover:
Related Issue
#162
Motivation and Context
This pull request addresses potential data leaks regarding authorization headers. The changes ensure that sensitive information is handled securely and that the
HttpStep
class can handle various HTTP methods. The comprehensive unit tests help prevent regressions and ensure that the class behaves as expected under different conditions.Types of changes
Checklist: