Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat - Also support reading a dict representing a json doc #172

Merged
merged 1 commit into from
Feb 27, 2025
Merged

feat - Also support reading a dict representing a json doc #172

merged 1 commit into from
Feb 27, 2025

Conversation

menathan
Copy link
Contributor

Description

Related Issue

#171

Motivation and Context

How Has This Been Tested?

...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@menathan menathan requested a review from a team as a code owner February 27, 2025 09:20
@menathan menathan force-pushed the feature/inmemorydatareader-json branch from 315bcf6 to 94bb77e Compare February 27, 2025 10:07
dannymeijer
dannymeijer approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@dannymeijer dannymeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannymeijer dannymeijer added the enhancement New feature or request label Feb 27, 2025
@dannymeijer dannymeijer added this to the 0.11 milestone Feb 27, 2025
@dannymeijer dannymeijer linked an issue Feb 27, 2025 that may be closed by this pull request
[FEATURE] Also support reading a dict representing a json #171
Closed
@dannymeijer dannymeijer merged commit d6ef80d into Nike-Inc:main Feb 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannymeijer dannymeijer dannymeijer approved these changes

Assignees

@menathan menathan

@dannymeijer dannymeijer

Labels
enhancement New feature or request
Projects
Koheesio
Status: Done
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

[FEATURE] Also support reading a dict representing a json
2 participants
@menathan @dannymeijer