Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Sparksession #31

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

sarathchandrabandaru
Copy link
Contributor

@sarathchandrabandaru sarathchandrabandaru commented Sep 12, 2023

Helps with using with any session configs we add prior to this and make spark expectations less intrusive.

Motivation and Context

It helps to no override some default configs and spark listeners added in spark while submitting.

How Has This Been Tested?

Unittests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…tive one. Helps with using with any session configs we add prior to this and make spark expectations less intrusive.
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f5b3ea5) 100.00% compared to head (02a7919) 100.00%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1369      1361    -8     
=========================================
- Hits          1369      1361    -8     
Files Changed Coverage Δ
spark_expectations/core/__init__.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asingamaneni
Copy link
Collaborator

@sarathchandrabandaru thanks for your first contribution!

@asingamaneni asingamaneni merged commit ae79f7b into Nike-Inc:main Sep 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants