Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply spell checks #67

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

SamyCoenen
Copy link
Contributor

@SamyCoenen SamyCoenen commented Jan 17, 2024

Description

The changes only cover documentation changes, mostly spelling mistakes or misplaced dots.

Related Issue

Motivation and Context

Easier to read documentation without mistakes.

How Has This Been Tested?

Built-in IDE spell check

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c87e21) 100.00% compared to head (9579bab) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1447      1453    +6     
=========================================
+ Hits          1447      1453    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamyCoenen
Copy link
Contributor Author

Hi @asingamaneni @Umeshsp22, can you have a look at this PR?

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing to the documentation.

@asingamaneni asingamaneni merged commit 426ec27 into Nike-Inc:main Feb 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants