v1.18.4 fix another bug with removal from queue

NikhilNarayana · Feb 23, 2020 · 2e63825 · 2e63825
1 parent 800b865
commit 2e63825
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/meleeuploader/forms.py b/meleeuploader/forms.py
@@ -174,7 +174,7 @@ def __init__(self):
 
         # Queue
         self._queue = Queue()
-        self._queueref = []
+        self._queueref = [] # out of order access to all the items in _queue with mutation
         consts.startQueue = True if "-q" in sys.argv else False
 
         # Event Values
@@ -525,6 +525,7 @@ def __update_qview(self, row, options):
     def __delete_from_queue_view(self, job_num):
         if not self._queueref[job_num].ignore:
             self._queueref[job_num].ignore = True
+            self._queueref.pop(job_num)
             self._qview -= job_num
 
     def __save_queue(self):

diff --git a/meleeuploader/youtube.py b/meleeuploader/youtube.py
@@ -106,6 +106,10 @@ def upload_service(insert_request):
 
 
 def test_get_service(scope, service, secret=None):
+    """
+    WIP
+    Based on the newer google_auth_oauthlib module
+    """
     CLIENT_SECRETS_FILE = get_secrets(PREFIXES, SUFFIXES) if not secret else secret
 
     if not CLIENT_SECRETS_FILE:

diff --git a/setup.py b/setup.py
@@ -4,7 +4,7 @@
 from os import path
 
 here = path.abspath(path.dirname(__file__))
-version = '1.18.3'
+version = '1.18.4'
 
 long_des = ""
 with open(path.join(here, 'README.md')) as f: