Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new backend to multiprecision to be used exclusively with modular_adaptor, remove all code that belongs to boost [SyncWith: crypto3-multiprecision#70] #66

Merged
merged 1 commit into from
May 15, 2024
Merged

Add a new backend to multiprecision to be used exclusively with modular_adaptor, remove all code that belongs to boost [SyncWith: crypto3-multiprecision#70] #66

merged 1 commit into from
May 15, 2024

Conversation

martun
Copy link
Contributor

@martun martun commented Apr 16, 2024 •
edited
Loading

  • Created a new cpp_int_modular backend, by changing the code of cpp_int.
  • Deleted all the code of boost that we did not touch and could include instead.
  • Changed nil::crypto3::multiprecision to boost::multiprecision, because otherwise we would need to copy boost into our repo and change all the namespaces.
  • Optimized modular adaptor, now it's only fixed length. This works much faster than non-fixed length.

P.S. From tests only test_modular_adaptor_fixed.cpp, test_inverse.cpp and test_ressol.cpp work. We have a separate task to fix all the tests that I have not deleted. Please do not review those tests.

@martun martun requested review from Zerg1996 and x-mass April 16, 2024 12:16
@martun martun force-pushed the clean_multiprecision_more branch 2 times, most recently from bee68a8 to 4db79d4 Compare April 16, 2024 12:34
@martun martun marked this pull request as draft April 16, 2024 12:40
@martun martun force-pushed the clean_multiprecision_more branch from ae96560 to 108e480 Compare April 16, 2024 12:48
@martun martun marked this pull request as ready for review April 16, 2024 12:50
@martun martun marked this pull request as draft April 17, 2024 08:23
@martun martun force-pushed the clean_multiprecision_more branch 3 times, most recently from 52675ee to dead8ec Compare April 26, 2024 16:22
@martun martun force-pushed the clean_multiprecision_more branch 2 times, most recently from 2790afb to 910b5eb Compare May 6, 2024 14:09
@martun martun force-pushed the clean_multiprecision_more branch 2 times, most recently from f265b96 to 2a191d6 Compare May 8, 2024 06:05
@martun martun changed the title Cleaned multiprecision, now we use a custom backend for cpp_int. Add a new backend to multiprecision to be used exclusively with modular_adaptor, remove all code that belongs to boost May 8, 2024
@martun martun self-assigned this May 8, 2024
@martun martun linked an issue May 8, 2024 that may be closed by this pull request
Add a new backend to multiprecision to be used exclusively with modular_adaptor, remove all code that belongs to boost. #70
Closed
@martun martun changed the title Add a new backend to multiprecision to be used exclusively with modular_adaptor, remove all code that belongs to boost Add a new backend to multiprecision to be used exclusively with modular_adaptor, remove all code that belongs to boost [SyncWith: crypto3-multiprecision#70] May 8, 2024
@martun martun marked this pull request as ready for review May 8, 2024 06:14
@martun martun mentioned this pull request May 8, 2024
Closed
@martun martun force-pushed the clean_multiprecision_more branch 2 times, most recently from b9db3e7 to 524b928 Compare May 8, 2024 13:17
@nil-foundation-cicd-bot nil-foundation-cicd-bot bot mentioned this pull request May 8, 2024
Closed
@nil-foundation-cicd-bot
Copy link

Tests will be run in sync with other PRs containing [SyncWith NilFoundation/crypto3-multiprecision#70] in title. You can find related PRs as linked with mentioned issue.

@martun martun force-pushed the clean_multiprecision_more branch 5 times, most recently from b98584f to 43e77a7 Compare May 9, 2024 10:56
@martun martun force-pushed the clean_multiprecision_more branch 7 times, most recently from 2925856 to 7abffac Compare May 10, 2024 10:00
x-mass
x-mass reviewed May 10, 2024
View reviewed changes
include/nil/crypto3/multiprecision/cpp_int_modular.hpp Show resolved Hide resolved
include/nil/crypto3/multiprecision/cpp_int_modular.hpp Outdated Show resolved Hide resolved
include/nil/crypto3/multiprecision/cpp_int_modular.hpp Show resolved Hide resolved
include/nil/crypto3/multiprecision/cpp_int_modular.hpp Show resolved Hide resolved
include/nil/crypto3/multiprecision/cpp_int_modular.hpp Show resolved Hide resolved
include/nil/crypto3/multiprecision/cpp_int_modular.hpp Outdated Show resolved Hide resolved
include/nil/crypto3/multiprecision/cpp_int_modular.hpp Outdated Show resolved Hide resolved
include/nil/crypto3/multiprecision/modular/modular_adaptor.hpp Outdated Show resolved Hide resolved
test/constexpr_test_cpp_int.cpp Outdated Show resolved Hide resolved
include/nil/crypto3/multiprecision/modular/modular_adaptor.hpp Show resolved Hide resolved
@martun martun force-pushed the clean_multiprecision_more branch 7 times, most recently from 4433d9e to c60fcb7 Compare May 13, 2024 13:28
@x-mass x-mass mentioned this pull request May 13, 2024
Open
@martun martun force-pushed the clean_multiprecision_more branch 5 times, most recently from 7aaf6b6 to 6161c51 Compare May 15, 2024 07:30
@martun martun force-pushed the clean_multiprecision_more branch from 6161c51 to 666269f Compare May 15, 2024 07:59
@martun martun force-pushed the clean_multiprecision_more branch from 666269f to 3eb9cef Compare May 15, 2024 11:59
@martun martun merged commit f7b49f1 into master May 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x-mass x-mass x-mass approved these changes

@Zerg1996 Zerg1996 Awaiting requested review from Zerg1996

Assignees

@martun martun

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@martun @x-mass