This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Fix signature in message response in order to fix hardhat deploy #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtrskv
force-pushed
the
fix-hardhat-test-deploy
branch
from
d841d6c to
faae278
Compare
dmtrskv
force-pushed
the
fix-hardhat-test-deploy
branch
from
faae278 to
58aa05a
Compare
Rolaman
reviewed
Jul 15, 2024
Rolaman
approved these changes
Jul 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardhat test hanged, because it received an incorrect signature and somehow ate the error (I found it during debug).
We need to return anything of 64 bytes with
0xprefix if the signature is empty.After that it hanged due to the block number always being 0 (it tries to get enough confirmations). Fixed getting block number here as well.
package-lock.json is updated this way each time I run
npm install, so why not commit it as well.