Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove viem encoding #86

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Remove viem encoding #86

merged 1 commit into from
Jul 8, 2024

Conversation

ukorvl
Copy link
Member

@ukorvl ukorvl commented Jul 3, 2024

This diff replaces all viem api except encodeFunctionData in the codebase. Some encoding methods added.
Related to #53 but not closing yet.

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 9d88eb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nilfoundation/niljs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ukorvl ukorvl requested a review from KlonD90 July 3, 2024 11:28
@ukorvl ukorvl self-assigned this Jul 3, 2024
@ukorvl ukorvl force-pushed the 53-remove-viem branch 4 times, most recently from 99fbe9d to 314612f Compare July 3, 2024 12:00
Copy link
Contributor

@KlonD90 KlonD90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge after eth-cc

@ukorvl ukorvl marked this pull request as draft July 3, 2024 12:59
@ukorvl ukorvl marked this pull request as ready for review July 8, 2024 12:05
@ukorvl ukorvl merged commit 0a7cfa0 into master Jul 8, 2024
2 checks passed
@ukorvl ukorvl mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants