Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiprecision refactoring #98

Draft
wants to merge 69 commits into
base: master
Choose a base branch
from
Draft

Multiprecision refactoring #98

wants to merge 69 commits into from

Conversation

ioxid
Copy link
Contributor

@ioxid ioxid commented Oct 18, 2024

No description provided.

@ioxid ioxid requested a review from martun October 18, 2024 16:07
@ioxid ioxid self-assigned this Oct 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Clang Test Results

  161 files  +  8    161 suites  +8   12m 19s ⏱️ -1s
3 580 tests + 39  3 574 ✅ + 39  6 💤 ±0  0 ❌ ±0 
3 765 runs  +164  3 759 ✅ +164  6 💤 ±0  0 ❌ ±0 

Results for commit e87f45c. ± Comparison against base commit 925420c.

This pull request removes 6 and adds 45 tests. Note that renamed tests count towards both. 
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4

addition ‑ does_not_wrap
addition ‑ does_not_wrap_rev
addition ‑ multilimb
addition ‑ multilimb_rev
addition ‑ simple
convert ‑ from_int64_t
convert ‑ from_uint64_t
convert ‑ to_uint64_t
cpp_int_conversion ‑ from_cpp_int
cpp_int_conversion ‑ to_cpp_int
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Gcc Test Results

  161 files  + 8    161 suites  +8   14m 12s ⏱️ -2s
3 582 tests +41  3 576 ✅ +41  6 💤 ±0  0 ❌ ±0 
3 668 runs  +67  3 662 ✅ +67  6 💤 ±0  0 ❌ ±0 

Results for commit e87f45c. ± Comparison against base commit 925420c.

♻️ This comment has been updated with latest results.

@ioxid ioxid force-pushed the multiprecision-refactoring branch 3 times, most recently from 656991a to f0ffd23 Compare November 4, 2024 13:32
@ioxid ioxid force-pushed the multiprecision-refactoring branch 7 times, most recently from bc46774 to 2f18e78 Compare November 13, 2024 10:46
@ioxid
Remove unused division for modular
bd5face
@ioxid
Clean up big_mod
8d4c40d
@ioxid
Clean up macros
4b1e0b6
@ioxid
Remove storage.hpp from big_uint export
f4ac833
@ioxid
Add comments
39f3101
@ioxid
Clean up signed big int and limits
aec78f4
@ioxid
Clean up comments
898a064
@ioxid
Fix constructor from signed int in big_mod_ct
99ccfcb
@ioxid
Use montgomery_big_mod_rt in ressol
ad5f155
@ioxid
Clean up comments
4b17f30
@ioxid
Remove inline where it is implicit
898976b
@ioxid
Use std::size_t instead of unsigned
455cfce
@ioxid
Use std::size_t instead of just size_t
e60caac
@ioxid
Use static constexpr instead of constexpr static
db0042e
@ioxid
Rename "size" to "limbs_count"
7bd95da
@ioxid
Fix UB in lsb of 0
0614fe7
@ioxid
Use limb_bits instead of sizeof
58fcced
@ioxid
Reintroduce some asserts in import export
7ad9a27
@ioxid
Add comment about using montgomery modular big integers in ressol
1b509f3
@ioxid
Add missing headers
1315c36
@ioxid
Fix monty_inverse
1d4d861
@ioxid
Add support for 64-bit limb_type when int128_t is available
4b345c8
@ioxid
Delete useless limb_type definitions
e87f45c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martun martun Awaiting requested review from martun

At least 1 approving review is required to merge this pull request.

Assignees

@ioxid ioxid

Labels
multiprecision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ioxid