Fix some Nix flake issues #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux Test Results 57 files 57 suites 3m 35s ⏱️ Results for commit ec6bfda. ♻️ This comment has been updated with latest results. |
|
Failure of the test is fine: |
|
Rebase? |
Specify build type with dedicated Nix option instead of raw flag. This doesn't change much, just makes it a bit cleaner.
`BUILD_SHARED_LIBS` has no effect since the library is header-only.
Previous note was inaccurate.
x-mass
approved these changes
Jun 28, 2024
AndreyMlashkin
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bunch of small improvements to
flake.nix. Some of them are referenced to issues.Resolves #398, resolves #399, resolves #401