chore: Update nilup curl URL to include install.sh #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the URL used to instruct users to install nilup to include the /install.sh path. Even though the root path (/) is essentially an alias for /install.sh, we shouldn't lock ourselves into that forever being the case.
cmacrae
approved these changes
Apr 1, 2024
|
@oceans404 I see there's a CI failure. Is this OK to merge despite it? |
This commit updates nilup-install docs to include a note about piping to bash going against conventional security wisdom and to show our users support in inspecting what the install.sh script does before running it blindly from their machine.
docs: Highlight piping to bash goes against conventional wisdom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the URL used to instruct users to install nilup to include the /install.sh path. Even though the root path (/) is essentially an alias for /install.sh, we shouldn't lock ourselves into that forever being the case.