wrappng with the basic changes

NiranjanNlc · Jan 26, 2022 · 4890d16 · 4890d16
1 parent d2fa2a3
commit 4890d16
Show file tree

Hide file tree

Showing 5 changed files with 59 additions and 32 deletions.
diff --git a/app/src/main/java/com/example/articlereader/utility/ArticleList.kt b/app/src/main/java/com/example/articlereader/utility/ArticleList.kt
@@ -7,61 +7,88 @@ object ArticleList
     fun getArtcile():List<Article>
     {
         return  listOf(
-            Article(title="https://review.firstround.com/draw-the-owl-and-other-company-values-you-didnt-know-you-should-have",
+            Article( title ="Draw the own",
+                url="https://review.firstround.com/draw-the-owl-and-other-company-values-you-didnt-know-you-should-have",
                 status = "Unread", titleImageUrl ="https://assets.proof.pub/2056/firstround/PonLXGamRvepsD1UrlvR_FR_CEO15_0189.jpg"),
-            Article(title="https://dunn.medium.com/make-a-big-deal-about-the-little-things-49044db95b3f",
+            Article( title ="Make Big Deal About Little Thng ",
+                url="https://dunn.medium.com/make-a-big-deal-about-the-little-things-49044db95b3f",
                 status = "Unread", titleImageUrl ="https://miro.medium.com/max/1400/1*StItySF9EEeRuYLLuhPOwA.png"),
-            Article(title="https://build.affinity.co/learn-fast-and-read-things-why-and-how-we-started-a-technical-reading-group-56a61db515bd",
+            Article( title ="Learn Fast and read thngs",
+                url="https://build.affinity.co/learn-fast-and-read-things-why-and-how-we-started-a-technical-reading-group-56a61db515bd",
                 status = "Unread", titleImageUrl ="https://miro.medium.com/max/1400/1*MGyu3fwG4VQLVp4w0OBTDA.jpeg"),
-            Article(title="https://review.firstround.com/6-small-steps-for-handling-the-emotional-ups-and-downs-at-work",
+            Article( title ="Handling E-motional Ups and Downs",
+                url="https://review.firstround.com/6-small-steps-for-handling-the-emotional-ups-and-downs-at-work",
                 status = "Unread", titleImageUrl ="https://assets.proof.pub/2056/firstround/YKE4NN6GSdCrH2JvJ16d_GettyImages-135258374.jpg"),
-            Article(title="https://dev.to/jlhcoder/dont-worry-about-failureembrace-it",
+            Article( title ="Don't Worry About Failure",
+                url="https://dev.to/jlhcoder/dont-worry-about-failureembrace-it",
                 status = "Unread", titleImageUrl ="https://res.cloudinary.com/practicaldev/image/fetch/s--SBksAfIF--/c_imagga_scale,f_auto,fl_progressive,h_100,q_auto,w_100/https://dev-to-uploads.s3.amazonaws.com/uploads/user/profile_image/654631/ecf6e602-04ee-45d4-a290-62df4a340b63.png"),
-            Article(title="https://medium.com/servant-leadership/failure-as-a-service-937473b0c9b8",
+            Article( title ="Failure As a service",
+                url="https://medium.com/servant-leadership/failure-as-a-service-937473b0c9b8",
                 status = "Unread", titleImageUrl ="https://miro.medium.com/max/1400/1*knEW6Xun2oOS7YHQbTjm_Q.jpeg"),
-            Article(title="http://blog.eladgil.com/2017/08/feelings-of-failure.html",
+            Article( title ="Feeling of failure "
+                ,url="http://blog.eladgil.com/2017/08/feelings-of-failure.html",
                 status = "Unread", titleImageUrl ="https://miro.medium.com/max/1400/1*knEW6Xun2oOS7YHQbTjm_Q.jpeg"),
-            Article(title="https://www.mindful.org/5-ways-build-resilience-every-day/",
+            Article( title ="Build Resilleence EveryDay",
+                url="https://www.mindful.org/5-ways-build-resilience-every-day/",
                 status = "Unread", titleImageUrl ="https://i0.wp.com/www.mindful.org/content/uploads/2016/08/alidina_resilience.jpg?w=740&ssl=1"),
-            Article(title="https://medium.com/glitch/gratitude-as-a-company-value-4bc9c8f0a4fc",
+            Article( title ="Grattiude as a company value",
+                url="https://medium.com/glitch/gratitude-as-a-company-value-4bc9c8f0a4fc",
                 status = "Unread", titleImageUrl ="https://miro.medium.com/max/3000/1*quN5xHu4FrqzI6gppWuYEA.jpeg"),
-            Article(title="https://corporate-rebels.com/iceberg-of-ignorance/",
+            Article( title ="Iceberg of ignorance",
+                url="https://corporate-rebels.com/iceberg-of-ignorance/",
                 status = "Unread", titleImageUrl ="https://corporate-rebels.com/CDN/571-1140x0.jpg"),
-            Article(title="https://www.strategy-business.com/blog/Put-an-End-to-Your-Feedback-Loop",
+            Article( title ="Put an end to feedback Loop",
+                url="https://www.strategy-business.com/blog/Put-an-End-to-Your-Feedback-Loop",
                 status = "Unread", titleImageUrl ="https://www.strategy-business.com/media/image/39246762_456x264.jpg"),
-            Article(title="https://sambleckley.com/writing/church-of-interruption.html",
+            Article( title ="Church of interruption",
+                url="https://sambleckley.com/writing/church-of-interruption.html",
                 status = "Unread", titleImageUrl ="https://sambleckley.com/assets/images/interruption.png"),
-            Article(title="https://medium.com/swlh/get-out-of-your-head-how-to-quiet-your-thoughts-1e239199dff9#---0-86%20%7C",
+            Article( title ="Quite Your Thoughts",
+                url="https://medium.com/swlh/get-out-of-your-head-how-to-quiet-your-thoughts-1e239199dff9#---0-86%20%7C",
                 status = "Unread", titleImageUrl ="https://miro.medium.com/max/700/1*4Mm2Vqe7hTZMNKRc6jaGZQ.jpeg"),
-            Article(title="https://www.strategy-business.com/article/The-Problem-of-Virtuous-Leadership",
+            Article( title ="Problem of virtuous leaddership",
+                url="https://www.strategy-business.com/article/The-Problem-of-Virtuous-Leadership",
                 status = "Unread", titleImageUrl ="https://assets.proof.pub/2056/firstround/OLMAkUk0RLWDMNcWyMvO_VNTR1822.jpg"),
-            Article(title="https://review.firstround.com/how-this-head-of-engineering-boosted-transparency-at-instagram",
+            Article( title ="Transparency at instragram",
+                url="https://review.firstround.com/how-this-head-of-engineering-boosted-transparency-at-instagram",
                 status = "Unread", titleImageUrl ="https://assets.proof.pub/2056/firstround/OLMAkUk0RLWDMNcWyMvO_VNTR1822.jpg"),
-            Article(title="https://inteamwetrust.com/2016/06/22/trust-toolbox-for-virtual-teams-module-1/",
+            Article( title ="Trust Tool Box",
+                url="https://inteamwetrust.com/2016/06/22/trust-toolbox-for-virtual-teams-module-1/",
                 status = "Unread", titleImageUrl ="https://inteamwetrust.files.wordpress.com/2016/06/d0b1d0b5d0b7-d0b7d0b0d0b3d0bed0bbd0bed0b2d0bad0b0-e1569397969805.png"),
-            Article(title="https://www.mindtools.com/pages/article/building-trust-team.htm",
+            Article( title ="Building Trust Team",
+                url="https://www.mindtools.com/pages/article/building-trust-team.htm",
                 status = "Unread", titleImageUrl ="https://www.mindtools.com/media/Resized-Images/Articles/Team_Management/24_IS_22354906_BorisJovanovic19_2x1.jpg"),
-            Article(title="https://agilecoach.typepad.com/agile-coaching/2010/08/building-trust.html",
+            Article( title ="Agile Coaching",
+                url="https://agilecoach.typepad.com/agile-coaching/2010/08/building-trust.html",
                 status = "Unread", titleImageUrl ="https://miro.medium.com/max/2000/0*azywUzeP9TzGhfvB"),
-            Article(title="https://dvirsegal.medium.com/building-trust-through-effective-communication-c00bf9b65c78",
+            Article( title ="Building Trust",
+                url="https://dvirsegal.medium.com/building-trust-through-effective-communication-c00bf9b65c78",
                 status = "Unread", titleImageUrl ="https://miro.medium.com/max/2000/0*azywUzeP9TzGhfvB"),
-            Article(title="https://knowyourteam.com/blog/2019/02/01/the-bottom-line-benefits-of-building-trust-in-the-workplace/",
+            Article( title ="Bottom line benefits of trust",
+                url="https://knowyourteam.com/blog/2019/02/01/the-bottom-line-benefits-of-building-trust-in-the-workplace/",
                 status = "Unread", titleImageUrl ="https://knowyourteam.com/blog/wp-content/uploads/2019/02/Untitled_Artwork-1024x551.jpg"),
-            Article(title="https://opensource.com/open-organization/16/10/building-organizational-trust",
+            Article( title ="Building organizational trust",
+                url="https://opensource.com/open-organization/16/10/building-organizational-trust",
                 status = "Unread", titleImageUrl ="https://opensource.com/sites/default/files/styles/image-full-size/public/lead-images/BIZ_HighTrust_1110_A.png?itok=EF5Tmcdk"),
-            Article(title="https://review.firstround.com/humans-hate-being-spun-how-to-practice-radical-honesty-from-the-woman-who-defined-netflixs-culture",
+            Article( title ="Practise Radical Honesty",
+                url="https://review.firstround.com/humans-hate-being-spun-how-to-practice-radical-honesty-from-the-woman-who-defined-netflixs-culture",
                 status = "Unread", titleImageUrl ="https://assets.proof.pub/2056/firstround/1x0s4s13SB2OUNsHwBbe_maxresdefault.jpg"),
-            Article(title="https://hbr.org/2017/01/the-neuroscience-of-trust",
+            Article( title ="Neuroscience of Trust",url="https://hbr.org/2017/01/the-neuroscience-of-trust",
                 status = "Unread", titleImageUrl ="https://assets.proof.pub/2056/firstround/NaY26azBTCyxurgtbXWu_TrustonTeams.jpg"),
-            Article(title="https://review.firstround.com/our-6-must-reads-for-creating-and-accelerating-trust-on-teams",
+            Article( title ="Creating and acclerating trust on team",
+                url="https://review.firstround.com/our-6-must-reads-for-creating-and-accelerating-trust-on-teams",
                 status = "Unread", titleImageUrl ="https://assets.proof.pub/2056/firstround/NaY26azBTCyxurgtbXWu_TrustonTeams.jpg"),
-            Article(title="https://inteamwetrust.com/2020/03/24/team-trust-canvas-session-online/",
+            Article( title ="Team trust canvas sesson online",
+                url="https://inteamwetrust.com/2020/03/24/team-trust-canvas-session-online/",
                 status = "Unread", titleImageUrl ="https://inteamwetrust.files.wordpress.com/2020/03/5306bd1b-9733-4456-a8c9-3a46994df2b0.png?w=720&h=523"),
-            Article(title="https://knowyourteam.com/blog/2019/02/12/the-3-most-effective-ways-to-build-trust-as-a-leader/",
+            Article( title ="Build Trust as a leader",
+                url="https://knowyourteam.com/blog/2019/02/12/the-3-most-effective-ways-to-build-trust-as-a-leader/",
                 status = "Unread", titleImageUrl ="https://knowyourteam.com/blog/wp-content/uploads/2019/02/building_blocks-1024x564.jpg"),
-            Article(title="https://inteamwetrust.com/team-trust-toolbox/trust-anti-pattern-cards/",
+            Article( title ="Trust antipattern Cards",
+                url="https://inteamwetrust.com/team-trust-toolbox/trust-anti-pattern-cards/",
                 status = "Unread", titleImageUrl ="https://inteamwetrust.files.wordpress.com/2019/09/img_5305-e1568640557156.jpg?w=720&h=540"),
-            Article(title="https://medium.com/@orenellenbogen/who-should-own-your-engineering-team-s-skill-debt-3c3f07bbefe9",
+            Article( title ="Owner of team skill debt",
+                url="https://medium.com/@orenellenbogen/who-should-own-your-engineering-team-s-skill-debt-3c3f07bbefe9",
                 status = "Unread", titleImageUrl ="https://miro.medium.com/max/1400/1*9MIXeNmTsxYU5JTEmjEFPw.jpeg"),
         )
 

diff --git a/app/src/main/java/com/example/articlereader/view/ArticleAdapter.kt b/app/src/main/java/com/example/articlereader/view/ArticleAdapter.kt
@@ -34,8 +34,8 @@ class ArticleAdapter constructor(val context : Context, val itemClickListener: I
     inner  class ArticleListViewHolder(var items: ArticleItemBinding): RecyclerView.ViewHolder(items.root)
     {
         init {
-            items.root.setOnClickListener{
-               it1 -> itemClickListener.onItemClick(items.article)
+            items.cardView.setOnClickListener{
+            itemClickListener.onItemClick(items.article!!)
             }
 
         }

diff --git a/app/src/main/java/com/example/articlereader/view/ListingActivty.kt b/app/src/main/java/com/example/articlereader/view/ListingActivty.kt
@@ -79,5 +79,6 @@ class ListingActivty : AppCompatActivity(),ArticleAdapter.ItemClickListener
         println(" Nlc user here $article.toString()")
         i.putExtra("url",article.url)
         startActivity(i,null)
+      //  finish()
     }
 }
diff --git a/app/src/main/res/layout/article_item.xml b/app/src/main/res/layout/article_item.xml
@@ -28,7 +28,6 @@
                 android:layout_width="match_parent"
                 android:layout_height="@dimen/album_cover_height"
                 android:background="?attr/selectableItemBackgroundBorderless"
-                android:clickable="true"
                 android:scaleType="fitXY" />
 
             <TextView

diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
@@ -9,7 +9,7 @@
         <dimen name="backdrop_title">30dp</dimen>
         <dimen name="backdrop_subtitle">18dp</dimen>
         <dimen name="card_margin">5dp</dimen>
-        <dimen name="card_album_radius">0dp</dimen>
+        <dimen name="card_album_radius">4dp</dimen>
         <dimen name="album_cover_height">160dp</dimen>
         <dimen name="album_title_padding">10dp</dimen>
         <dimen name="album_title">15dp</dimen>