forked from trussed-dev/trussed
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virt: adapt to trussed-dev/littlefs2#24 #12
Open
daringer
wants to merge
50
commits into
main
Choose a base branch
from
lfs2-lookahead
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rng` feature is replaced by rand_chacha
Signed-off-by: alt3r 3go <[email protected]>
Signed-off-by: alt3r 3go <[email protected]>
Signed-off-by: alt3r 3go <[email protected]>
Signed-off-by: alt3r 3go <[email protected]>
Signed-off-by: alt3r 3go <[email protected]>
Signed-off-by: alt3r 3go <[email protected]>
Signed-off-by: alt3r 3go <[email protected]>
Signed-off-by: alt3r 3go <[email protected]>
Signed-off-by: alt3r 3go <[email protected]>
In a separate commit for better visibility. Removed addressed TODOs, reworded those that should stay for later (magic numbers), rebased to the latest "main". Signed-off-by: alt3r 3go <[email protected]>
rsa2k -> rsa2048 rsa3k -> rsa3072 rsa4k -> rsa4096
Fido-authenticator depended on its length. This commit restores the old length changes only the length of the (de)serialize_key methods to minimize breakage
As RSA requires an allocator, it should no be enabled by default
This reverts commit 2909643. The update breaks the format and causes loss of existing U2F keys
In #38 [0], we restricted the operations for the hmacsha256 mechanism to symmetric and shared keys. This breaks fido-authenticator because it uses hmacsha256 derive_key on EC keys [1]. This patch relaxes the restrictions to allow all key kinds. [0] trussed-dev#38 [1] trussed-dev/fido-authenticator#21
For our fork, we don’t need to check compatibility with solokeys. And the nitrokey-3-firmware check isn’t active anyway.
Add RSA support
This is required for compatibility with nitrokey-3-firmware.
Patch littlefs2 dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: trussed-dev/littlefs2#24
enables usbip to work with the above changes/PR