Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add must_use attributes on futures. #35

Closed
wants to merge 1 commit into from
Closed

Add must_use attributes on futures. #35

wants to merge 1 commit into from

Conversation

sosthene-nitrokey
Copy link
Collaborator

Prior to that there would be no warning when forgetting to use (try_)syscall.

@sosthene-nitrokey
Add must_use attributes on futures.
9087c80 
Prior to that there would be no warning when forgetting to use `(try_)syscall`.
robin-nitrokey
robin-nitrokey approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think it would be easier to create and merge the PR for trussed-dev/trussed and then merge upstream main into our main so that we keep the changes in our fork minimal.

@sosthene-nitrokey
Copy link
Collaborator Author

Replaced with trussed-dev#146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-nitrokey robin-nitrokey robin-nitrokey approved these changes

@daringer daringer Awaiting requested review from daringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosthene-nitrokey @robin-nitrokey