Trivial linting #48
Merged
Trivial linting #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Autoformat the code with `black` for better readability - Replace `== True` with `is True` - Remove redundant parentheses in conditional statements - Replace `if not x in y:` with `if x not in y:` - Replace `!= None` with `is not None` - Use raw string (r"...") with regular expressions to avoid escaping issues (as recommended in the documentation of the `re` module).
vlinkz
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some linting issues while working on #47. I got warnings both in my IDE and when running
pytestand I assume that some of these warnings (like the string escaping issue with regular expressions) actually reach production.Changes:
blackfor better readability== Truewithis Trueif not x in y:withif x not in y:!= Nonewithis not Noneremodule).@vlinkz