Build nix-util-c with meson + unit tests #10955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
commented
Jun 25, 2024
roberth
force-pushed
the
meson-nix-util-c
branch
from
a7edd1d to
60cdfc8
Compare
Ericson2314
reviewed
Jun 25, 2024
Ericson2314
reviewed
Jun 25, 2024
src/libutil-c/meson.build
Outdated
Comment on lines
101
to
82
| # TODO rename, because it will conflict with downstream projects | ||
| configdata.set_quoted('PACKAGE_VERSION', meson.project_version()) | ||
|
|
||
| configdata.set_quoted('SYSTEM', host_machine.system()) |
There was a problem hiding this comment.
BTW the more we expose these things, the harder it will be to avoid rebuilds. Not a new things, but existing thing we might reconsider with the C libs.
Ericson2314
reviewed
Jun 25, 2024
Ericson2314
approved these changes
Jun 25, 2024
| include_directories : include_dirs, | ||
| link_with : this_exe, | ||
| compile_args : ['-std=c++2a'], | ||
| dependencies : [], |
There was a problem hiding this comment.
Suggested change
| dependencies : [], |
I defined this elsewhere, but I am now wondering whether it is even necessary or not.
There was a problem hiding this comment.
Or maybe it's "header deps" and so should be deps_public + subproject deps
There was a problem hiding this comment.
We can clean this up later :)
roberth
force-pushed
the
meson-nix-util-c
branch
2 times, most recently
from
f19c8e3 to
05ddea7
Compare
This should be slightly easier to read. We could apply this to all concatMapAttrs calls.
roberth
force-pushed
the
meson-nix-util-c
branch
from
05ddea7 to
ae3304b
Compare
|
Let's go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some more steps in the process of porting the build system to meson.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.