-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to nixpkgs-vet #101
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
[package] | ||
name = "nixpkgs-check-by-name" | ||
name = "nixpkgs-vet" | ||
version = "0.1.3" | ||
edition = "2021" | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,12 +27,12 @@ There is no guarantee that the derivation succeeds on systems that don't have [p | |
but it can be attempted with | ||
|
||
```bash | ||
nix-build https://github.com/NixOS/nixpkgs-check-by-name/tarball/master -A build | ||
nix-build https://github.com/NixOS/nixpkgs-vet/tarball/master -A build | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will be true on repository rename |
||
``` | ||
|
||
## Prebuilt store paths | ||
|
||
The [GitHub releases](https://github.com/NixOS/nixpkgs-check-by-name/releases) | ||
The [GitHub releases](https://github.com/NixOS/nixpkgs-vet/releases) | ||
contain a [gzip](https://en.wikipedia.org/wiki/Gzip)-compressed | ||
[Nix Archive](https://nixos.org/manual/nix/stable/command-ref/nix-store/export.html) | ||
of the [build closure](https://nixos.org/manual/nix/stable/glossary#gloss-closure) | ||
|
@@ -54,11 +54,11 @@ and is therefore much faster and less storage intensive. | |
## Binary interface | ||
|
||
The store path acquired from the above methods contains | ||
a `system`-specific binary under `$storePath/bin/nixpkgs-check-by-name`. | ||
a `system`-specific binary under `$storePath/bin/nixpkgs-vet`. | ||
|
||
The public interface of this binary is printed by calling | ||
```bash | ||
result/bin/nixpkgs-check-by-name --help | ||
result/bin/nixpkgs-vet --help | ||
``` | ||
|
||
## Validity checks | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,8 +51,8 @@ let | |
}; | ||
|
||
shell = pkgs.mkShell { | ||
env.NIX_CHECK_BY_NAME_NIX_PACKAGE = lib.getBin defaultNixPackage; | ||
env.NIX_CHECK_BY_NAME_NIXPKGS_LIB = "${nixpkgs}/lib"; | ||
env.NIXPKGS_VET_NIX_PACKAGE = lib.getBin defaultNixPackage; | ||
env.NIXPKGS_VET_NIXPKGS_LIB = "${nixpkgs}/lib"; | ||
env.RUST_SRC_PATH = "${pkgs.rustPlatform.rustLibSrc}"; | ||
inputsFrom = [ packages.build ]; | ||
nativeBuildInputs = with pkgs; [ | ||
|
@@ -156,7 +156,7 @@ let | |
# Tests the tool on the pinned Nixpkgs tree with stable Nix. This is a good sanity check. | ||
nixpkgsCheck = pkgs.callPackage ./nixpkgs-check.nix { | ||
inherit initNix nixpkgs; | ||
nixpkgs-check-by-name = packages.build; | ||
nixpkgs-vet = packages.build; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could do a redirect but ehhhh no users other than nixpkgs. |
||
nix = pkgs.nixVersions.stable; | ||
}; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
This test makes sure that if evaluating top-level attributes give warnings, they won't end up in | ||
the output, see https://github.com/NixOS/nixpkgs-check-by-name/issues/30 for more context | ||
the output, see https://github.com/NixOS/nixpkgs-vet/issues/30 for more context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Todo list for NixOS org owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to rename it myself as a team maintainer :)