Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include clippy lints for tests #28

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Include clippy lints for tests #28

merged 2 commits into from
Mar 26, 2024

Conversation

willbush
Copy link
Member

@willbush willbush commented Mar 26, 2024

Randomly noticed some warnings in main.rs since I improved my rust-analyzer integration in Emacs. Looked into why and apparently cargo clippy doesn't include tests by default:

rust-lang/rust-clippy#1436 (comment)
rust-lang/rust-clippy#10690

We could pass --all-targets or --tests to fix the issue. I liked the former because its more obvious that lints are checked for more than just tests.

@willbush willbush requested a review from a team as a code owner March 26, 2024 03:08
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, thanks!

@infinisil infinisil merged commit 65a04d8 into NixOS:main Mar 26, 2024
1 check passed
@willbush willbush deleted the clippy-lint-all-targets branch May 19, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants