-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anki-bin: init at 2.1.36 #106638
anki-bin: init at 2.1.36 #106638
Conversation
d7b4a06
to
7818fd6
Compare
/marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
@Atemu how do I test this? Just building and running from
|
Are you on wayland? Any QT environment variables set? I only tested this on Xorg and I don't think it'd work anywhere else. |
Yes, I am on Wayland, as Xorg doesn't work on my laptop properly. What would be the quickest way to launch, say, a window with Openbox inside to test an Xorg-only app?
|
It might be worth trying to run it in XWayland. Otherwise, |
I cleared my environment and after adding LANG and DISPLAY I can confirm the application launches. With the exception of a nitpick mentioned in my review above, this looks ready to merge. |
This comment has been minimized.
This comment has been minimized.
Oh, wait, I accidentally broke the bot. /status awaiting_changes |
/status needs_merger |
Since this already tripped up two people, I think we should add the wrapper. Clearing the environment seemed to work, do you know which variables were at fault? If not, @kisik21 could you try to find out? @Profpatsch I tend to agree with @Atemu that we don't need to explicitly migrate people. They can opt-in to anki-bin, and then they will notice once the package is no longer available. Having to replace |
Timo Kaufmann <[email protected]> writes:
> If it works in XWayland and there's an easy way to force that via a wrapper, I could at least do that.
Since this already tripped up two people, I think we should add the wrapper. Clearing the environment seemed to work, do you know which variables were at fault? If not, @kisik21 could you try to find out?
If you set `QT_QPA_PLATFORM=xcb`, Qt uses X11 to display windows. This
variable should be set in the wrapper.
…---
Sincerely,
Vika
|
I'll get on that when I get my AMDGPU on Wednesday and can actually use Wayland properly. Can't wait to finally be free of this blobby Nvidia crap. |
Thanks for digging into this @kisik21 :) No hurry, I'll just change the status so that marvin won't nag us. /status awaiting_changes |
Works around NixOS#78449 Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Vika <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on macOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Motivation for this change
Workaround for #78449
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)