Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-functions-core-tools: Add darwin support, upgrade to v4 #193902

Merged
merged 1 commit into from
Oct 11, 2022
Merged

azure-functions-core-tools: Add darwin support, upgrade to v4 #193902

merged 1 commit into from
Oct 11, 2022

Conversation

okpedersen
Copy link
Contributor

Description of changes

Add support for x86_64-darwin. Upgrade to v4, and allow building with non-dotnet function workers (runtimes must be installed separately).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package labels Oct 1, 2022
@ofborg ofborg bot requested a review from jshcmpbll October 1, 2022 12:50
jshcmpbll
jshcmpbll approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@jshcmpbll jshcmpbll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobby285271 bobby285271 added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 4, 2022
@viraptor viraptor merged commit 3456465 into NixOS:master Oct 11, 2022
@okpedersen okpedersen deleted the azure-functions-core-tools-darwin branch October 11, 2022 14:00
@JamieMagee JamieMagee mentioned this pull request Jan 7, 2023
Closed
13 tasks
@GGG-KILLER
Copy link
Contributor

GGG-KILLER commented Jan 8, 2023 •
edited
Loading

This leaves the tool using .NET Core 3.1 (which is also EOL) when it actually needs .NET 6, could you make a follow up PR @okpedersen?

EDIT: Nevermind, seems like it's being done in #209593 already, didn't see that one

@wegank wegank mentioned this pull request Jan 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshcmpbll jshcmpbll jshcmpbll approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@okpedersen @GGG-KILLER @jshcmpbll @viraptor @bobby285271