Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromiumDev: 112.0.5615.20 -> 113.0.5638.0 #220389

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

primeos
Copy link
Member

@primeos primeos commented Mar 9, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 9, 2023
@primeos primeos merged commit 867f13a into NixOS:master Mar 9, 2023
@raphaelr
Copy link
Contributor

Currently doesn't build, the error message doesn't look like it's related to our packaging:

FAILED: obj/third_party/blink/renderer/core/core/ng_grid_layout_algorithm.o
clang++ -MMD -MF obj/third_party/blink/renderer/core/core/ng_grid_layout_algorithm.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_OZONE=1 -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_>
../../third_party/blink/renderer/core/layout/ng/grid/ng_grid_layout_algorithm.cc:530:28: error: reference to local binding 'grid_items' declared in enclosing function 'blink::NGGridLayoutAlgorithm::BuildGridSizingSubtree'
    for (auto& grid_item : grid_items) {
                           ^
../../third_party/blink/renderer/core/layout/ng/grid/ng_grid_layout_algorithm.cc:512:10: note: 'grid_items' declared here
  auto& [grid_items, layout_data, subtree_size] =
         ^
../../third_party/blink/renderer/core/layout/ng/grid/ng_grid_layout_algorithm.cc:540:5: error: reference to local binding 'layout_data' declared in enclosing function 'blink::NGGridLayoutAlgorithm::BuildGridSizingSubtree'
    layout_data.SetTrackCollection(
    ^
../../third_party/blink/renderer/core/layout/ng/grid/ng_grid_layout_algorithm.cc:512:22: note: 'layout_data' declared here
  auto& [grid_items, layout_data, subtree_size] =
                     ^
2 errors generated.

@primeos
Copy link
Member Author

primeos commented Mar 11, 2023

@raphaelr thanks for the heads-up :) I fear that LLVM 15 might already be to "old" to build M113 (packaging Google software sucks) but that's just a guess. Anyway, I documented it here: #213862 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants