Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet-sdk_3: remove #222422

Merged
merged 1 commit into from
Mar 29, 2023
Merged

dotnet-sdk_3: remove #222422

merged 1 commit into from
Mar 29, 2023

Conversation

mdarocha
Copy link
Contributor

@mdarocha mdarocha commented Mar 21, 2023 •
edited
Loading

Also remove all reference to outdated .NET versions.

Description of changes

Remove .NET 3.1, which is EOL. Closes #202572

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Mar 21, 2023
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 21, 2023
GGG-KILLER
GGG-KILLER approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@GGG-KILLER GGG-KILLER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but shouldn't we keep the possibility to override the icu for the next time something like what happened in .NET Core 3.1 did?

@mdarocha
Copy link
Contributor Author

mdarocha commented Mar 22, 2023 •
edited
Loading

Everything looks good, but shouldn't we keep the possibility to override the icu for the next time something like what happened in .NET Core 3.1 did?

In such a case we can reference git history and bring back this code, I would prefer keeping it clean now that it's not needed.

@ajs124
Copy link
Member

ajs124 commented Mar 22, 2023

#214843 can be merged once this is in, right?

@mdarocha
Copy link
Contributor Author

#214843 can be merged once this is in, right?

yes

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1995

@mdarocha
dotnet-sdk_3: remove
43f7cc0 
Also remove all reference to outdated .NET versions.
@figsoda figsoda added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Mar 27, 2023
@ajs124 ajs124 merged commit 800426c into NixOS:master Mar 29, 2023
@mdarocha mdarocha deleted the remove-dotnet-3 branch March 29, 2023 14:17
@JamieMagee JamieMagee mentioned this pull request Jul 11, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@GGG-KILLER GGG-KILLER GGG-KILLER approved these changes

@IvarWithoutBones IvarWithoutBones Awaiting requested review from IvarWithoutBones

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dotnet 3.1 is EOL
6 participants
@mdarocha @ajs124 @nixos-discourse @GGG-KILLER @SuperSandro2000 @figsoda