chromiumBeta: Fix the build with LLVM 16 by reverting a commit #235053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts a small commit [0] that adds the flag "-disable-auto-upgrade-debug-info" as it requires an unreleased LLVM version or the build will fail with the following error message: ``` ld.lld: error: -mllvm: ld.lld: Unknown command line argument '-disable-auto-upgrade-debug-info'. Try: '/nix/store/bx494s1r30zwa7zdsyg72sjryy0k0pyg-llvm-binutils-16.0.1/bin/ld.lld --help' ld.lld: Did you mean '--disable-auto-paired-vec-st'? clang++: error: linker command failed with exit code 1 (use -v to see invocation) ``` See [1] for a full example output. Thanks to Lorenz Brun for the analysis/help [2]. [0]: chromium/chromium@5496976 [1]: NixOS#213862 (comment) [2]: NixOS#213862 (comment)
ofborg
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a small commit 0 that adds the flag "-disable-auto-upgrade-debug-info" as it requires an unreleased LLVM version or the build will fail with the following error message:
See 1 for a full example output.
Thanks to Lorenz Brun for the analysis/help 2.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)