Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jamesdsp: 2.6.0 -> 2.6.1 #249346

Merged
merged 3 commits into from
Aug 16, 2023
Merged

jamesdsp: 2.6.0 -> 2.6.1 #249346

merged 3 commits into from
Aug 16, 2023

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Audio4Linux/JDSP4Linux/releases.

meta.description for jamesdsp is: An audio effect processor for PipeWire clients

meta.homepage for jamesdsp is: https://github.com/Audio4Linux/JDSP4Linux

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 2.6.1 with grep in /nix/store/ppcqc5vw0livjv1pyady3cqks0gqsrp7-jamesdsp-2.6.1
  • found 2.6.1 in filename of file in /nix/store/ppcqc5vw0livjv1pyady3cqks0gqsrp7-jamesdsp-2.6.1

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
jamesdsp
jamesdsp-pulse
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/ppcqc5vw0livjv1pyady3cqks0gqsrp7-jamesdsp-2.6.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A jamesdsp https://github.com/r-ryantm/nixpkgs/archive/d20a72e91364f6fcd25f5d964fcc72c30f0d22dc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/ppcqc5vw0livjv1pyady3cqks0gqsrp7-jamesdsp-2.6.1
ls -la /nix/store/ppcqc5vw0livjv1pyady3cqks0gqsrp7-jamesdsp-2.6.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:
  • jamesdsp
  • jamesdsp-pulse

Maintainer pings

cc @pasqui23 @wineee for testing.

@ofborg ofborg bot requested review from wineee and pasqui23 August 15, 2023 15:08
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 15, 2023
@pasqui23
Copy link
Contributor

LGTM

@drupol
Copy link
Contributor

drupol commented Aug 15, 2023

@pasqui23 Hi, I added 2 commits in this PR, could you please let me know if it's OK for you?

@pasqui23
Copy link
Contributor

ok for me

@drupol drupol merged commit 7b66d3b into NixOS:master Aug 16, 2023
8 checks passed
@r-ryantm r-ryantm deleted the auto-update/jamesdsp branch August 16, 2023 11:02
@FavoritoHJS
Copy link
Contributor

requesting 23.05 backport, this patch fixes a bug that results in common, random crashes, see james34602/JamesDSPManager#47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants