Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: add optional phpSrc attribute #254556

Merged
merged 1 commit into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions pkgs/development/interpreters/php/generic.nix
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,12 @@ let
, jq

, version
, hash
, phpSrc ? null
, hash ? null
, extraPatches ? [ ]
, packageOverrides ? (final: prev: { })
, phpAttrsOverrides ? (attrs: { })
, pearInstallPhar ? (callPackage ./install-pear-nozlib-phar.nix { })

# Sapi flags
, cgiSupport ? true
Expand Down Expand Up @@ -192,6 +194,11 @@ let

mkWithExtensions = prevArgs: prevExtensionFunctions: extensions:
mkBuildEnv prevArgs prevExtensionFunctions { inherit extensions; };

defaultPhpSrc = fetchurl {
url = "https://www.php.net/distributions/php-${version}.tar.bz2";
inherit hash;
};
in
stdenv.mkDerivation (
let
Expand Down Expand Up @@ -278,6 +285,15 @@ let
substituteInPlace configure --replace "-lstdc++" "-lc++"
'';

# When compiling PHP sources from Github, this file is missing and we
# need to install it ourselves.
# On the other hand, a distribution includes this file by default.
preInstall = ''
if [[ ! -f ./pear/install-pear-nozlib.phar ]]; then
cp ${pearInstallPhar} ./pear/install-pear-nozlib.phar
fi
'';

postInstall = ''
test -d $out/etc || mkdir $out/etc
cp php.ini-production $out/etc/php.ini
Expand All @@ -291,10 +307,7 @@ let
$dev/share/man/man1/
'';

src = fetchurl {
url = "https://www.php.net/distributions/php-${version}.tar.bz2";
inherit hash;
};
src = if phpSrc == null then defaultPhpSrc else phpSrc;

patches = [ ./fix-paths-php7.patch ] ++ extraPatches;

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
fetchurl
}:

fetchurl {
url = "https://pear.php.net/install-pear-nozlib.phar";
hash = "sha256-UblKVcsm030tNSA6mdeab+h7ZhANNz7MkFf4Z1iigjs=";
}