haskellPackages.typerep-map: Fix build #258206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpscholten
requested review from
cdepillabout,
sternenseemann and
maralorn
as code owners
ofborg
bot
added
10.rebuild-darwin: 0
mpscholten
force-pushed
the
fix-typerep-map
branch
from
f9c729a to
3e876cf
Compare
| @@ -306619,7 +306619,6 @@ self: { | |||
| description = "Efficient implementation of a dependent map with types as keys"; | |||
| license = lib.licenses.mpl20; | |||
| hydraPlatforms = lib.platforms.none; | |||
There was a problem hiding this comment.
In practice, you also need to remove the hydraPlatforms = none line, since this line prevents Hydra from building this package!
Suggested change
| hydraPlatforms = lib.platforms.none; |
There was a problem hiding this comment.
Hmm, I'm not sure why, but GitHub isn't letting me commit this change from from the UI. @mpscholten could you commit this as well?
There was a problem hiding this comment.
Good catch, thanks! Yes will commit and rebase again 👍
There was a problem hiding this comment.
@cdepillabout just pushed the update 👍
mpscholten
force-pushed
the
fix-typerep-map
branch
from
3e876cf to
8e7c07d
Compare
|
@ofborg build haskellPackages.typerep-map |
|
ofborg likes it, at least on linux. Thanks @mpscholten, we appreciate it! |
|
Great! Thanks for the fast review :) |
ofborg
bot
added
8.has: package (new)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes the build of the
typerep-mappackage by using the PR at kowainik/typerep-map#128This patch has been used in IHP for a while and works well.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)