Electron updates #271677
Electron updates #271677
Conversation
ofborg
bot
added
11.by: package-maintainer
delroth
added
12.approvals: 1
ofborg
bot
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
electron/electron#39974 has been backported to 27.x Also now the patch used for versions older than 27 has been renamed to just "version.patch"
ofborg
bot
added
10.rebuild-darwin: 0
| @@ -18488,9 +18488,10 @@ with pkgs; | |||
| electron_22 = electron_22-bin; | |||
| electron_23 = electron_23-bin; | |||
| electron_24 = electron_24-bin; | |||
| electron_25 = if lib.meta.availableOn stdenv.hostPlatform electron-source.electron_25 then electron-source.electron_25 else electron_25-bin; | |||
| electron_25 = electron_25-bin; | |||
There was a problem hiding this comment.
Can we please keep this? Lots of things are still using electron 25 like bitwarden and I want to stay as blob free as possible.
Since we already have the patches and all the code it is currently no extra maintenance and if things break please give me a ping.
There was a problem hiding this comment.
It would not be built by hydra anyways, since it is EOL and thus marked as insecure
There was a problem hiding this comment.
According to https://endoflife.date/electron Electron 25 won't be EOL before January 2.
There was a problem hiding this comment.
Not according to their documentation.
There was a problem hiding this comment.
Then they changed this again. I've just recently updated all the dates in endoflife.date with the information available. endoflife-date/endoflife.date@a274819
It would not be built by hydra anyways, since it is EOL and thus marked as insecure
This is garbage. We must stop doing this. Just because something is EOL we cannot gate all the people not using it and requiring them to buy very good PCs.
This also breaks bitwarden desktop client. The ecosystem is just not as fast as electron updates and EOLs their software and there is not much we can do about this if we want to be able to use electron software.
ofborg
bot
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
There was a problem hiding this comment.
This patch would have been more fitting in the ./patches directory, but given https://github.com/NixOS/nixpkgs/blob/a7153d8843a2b087f69575a93653155c592b71ca/pkgs/applications/networking/browsers/chromium/cross-compile.patch also isn't in there, I will probably just move those two in some PR in the future.
(I will probably redo #264326 soon-ish)
|
PS: @yu-re-ka, would you be interested in some sort of chromium/electron coordination chat on Matrix? cc @networkException (all the other [edit: chromium] maintainers have been inactive for months and should probably get removed from |
|
Sure, yes |
|
I'm not opposed to being added to such a chat, but I'm not a chromium maintainer. I'm a firefox user and only use the chromium expression through electron (element-desktop, specifically). |
|
That's perfectly fine. I just thought of some sort of coordination chat because of how dependent It honestly slightly unsettles me how much but oh well. But it does have a couple of downsides from Fun fact: I am technically a chromium maintainer, but don't use Are you fine with me merging this PR, or is there anything left blocking? |
|
I'm fine with merging |
|
Successfully created backport PR for |
|
I am a pseudo chromium maintainer and am using chromium alas, not a lot of time available, but I do monitor what is going on and my silence is tacit approval, so feel free to poke me if you really need a chromium user perspective. :) |
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.