Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitwarden: 2023.10.1 -> 2023.12.0 #272541

Merged
merged 3 commits into from
Dec 10, 2023
Merged

bitwarden: 2023.10.1 -> 2023.12.0 #272541

merged 3 commits into from
Dec 10, 2023

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Dec 6, 2023 •
edited
Loading

Description of changes

Diff: bitwarden/clients@desktop-v2023.10.1...desktop-v2023.12.0

Changelog: https://github.com/bitwarden/clients/releases/tag/desktop-v2023.12.0

closes #273283
closes #272658

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from amarshall and Kiwi December 6, 2023 22:22
amarshall
amarshall approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@amarshall amarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified build and basic functionality of desktop app.

Verified build and bw --help for CLI.

I did build by cherry-picking these commits onto nixos-unstable (2c7f3c0) branch since didn’t feel like waiting for electron to build.

SuperSandro2000
SuperSandro2000 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test on my machine but looks good to me

amarshall
amarshall reviewed Dec 8, 2023
View reviewed changes
pkgs/tools/security/bitwarden/default.nix
preBuild = ''
# FIXME add back once upstream moves to Electron >= 26
# we use electron_26 because electron_25 is EOL
/*preBuild = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth asserting on version to force to re-evaluate on upgrade e.g.

preBuild = let skipCheck = lib.versionOlder version "2023.12.1"; in assert skipCheck; lib.optionalString (!skipCheck) ''
…

Don’t really care too much about the specific construction, just that it goes boom so we don’t forget about it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a comment behind the version attribute be sufficient?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea suppose that’s okay since it will be visible in the diff for a version bump.

@dotlambda
bitwarden: use electron_26
47a92aa 
Upstream uses Electron 25 which is EOL but the app runs fine under
Electron 26.
@dotlambda dotlambda force-pushed the bitwarden-2023.12.0 branch from dc4e745 to 47a92aa Compare December 9, 2023 02:03
@ofborg ofborg bot requested a review from amarshall December 9, 2023 08:17
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 10, 2023 •
edited
Loading

I am not sure if the following errors are related to using electron 26

01:28:13.617 › TypeError: Cannot read properties of undefined (reading 'deleteBiometricKey')
    at BiometricsService.<anonymous> (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:48310:55)
    at Generator.next (<anonymous>)
    at /nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:48218:71
    at new Promise (<anonymous>)
    at biometrics_service_awaiter (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:48214:12)
    at BiometricsService.deleteBiometricKey (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:48308:16)
    at DesktopCredentialStorageListener.<anonymous> (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:48517:45)
    at Generator.next (<anonymous>)
    at /nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:48394:71
    at new Promise (<anonymous>)
01:28:13.618 › TypeError: Cannot read properties of undefined (reading 'deleteBiometricKey')
    at BiometricsService.<anonymous> (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:48310:55)
    at Generator.next (<anonymous>)
    at /nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:48218:71
    at new Promise (<anonymous>)
    at biometrics_service_awaiter (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:48214:12)
    at BiometricsService.deleteBiometricKey (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:48308:16)
    at DesktopCredentialStorageListener.<anonymous> (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:48517:45)
    at Generator.next (<anonymous>)
    at /nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:48394:71
    at new Promise (<anonymous>)
(node:893169) UnhandledPromiseRejectionWarning: TypeError: Cannot read properties of undefined (reading 'setContextMenu')
    at TrayMain.updateContextMenu (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:47357:23)
    at MessagingMain.updateTrayMenu (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:46857:28)
    at MessagingMain.onMessage (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:46783:22)
    at MessagingMain.<anonymous> (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:46774:151)
    at Generator.next (<anonymous>)
    at /nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:46753:71
    at new Promise (<anonymous>)
    at messaging_main_awaiter (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:46749:12)
    at IpcMainImpl.<anonymous> (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:46774:79)
    at IpcMainImpl.emit (node:events:513:28)
(node:893169) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 22)

and when exiting:

01:28:25.591 › TypeError: Object has been destroyed
    at WindowMain.<anonymous> (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:47777:36)
    at Generator.next (<anonymous>)
    at /nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:47547:71
    at new Promise (<anonymous>)
    at window_main_awaiter (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:47543:12)
    at WindowMain.updateWindowState (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:47772:16)
    at WindowMain.<anonymous> (/nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:47706:28)
    at Generator.next (<anonymous>)
    at /nix/store/n501n5zszk113sq0wiyv47cxlqavhqgp-bitwarden-2023.12.0/opt/Bitwarden/resources/app.asar/main.js:47547:71
    at new Promise (<anonymous>)
Segmentation fault (core dumped)

otherwise LGTM

@dotlambda
Copy link
Member Author

TypeError: Cannot read properties of undefined (reading 'deleteBiometricKey')

Reading through the bitwarden/clients code this simply doesn't seem to be implemented for Linux.

@amarshall
Copy link
Member

The segfault on quit is not new, (un)fortunately.

@amarshall amarshall mentioned this pull request Dec 10, 2023
Closed
patka-123
patka-123 approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@patka-123 patka-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 272541 run on x86_64-linux 1

2 packages built:
  • bitwarden
  • bitwarden-cli

Looks good to me. Also tested some things manually and it seems to work well.

@dotlambda dotlambda merged commit 7eb0ff5 into NixOS:master Dec 10, 2023
10 of 11 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@dotlambda dotlambda deleted the bitwarden-2023.12.0 branch December 10, 2023 19:43
@github-actions github-actions bot mentioned this pull request Dec 10, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patka-123 patka-123 patka-123 approved these changes

@amarshall amarshall amarshall approved these changes

@Kiwi Kiwi Awaiting requested review from Kiwi

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: bitwarden
4 participants
@dotlambda @SuperSandro2000 @amarshall @patka-123