Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-23.05] rapidcheck: Simplify installation, update, pkg-config #280330

Merged
merged 3 commits into from
Jan 12, 2024
Merged

[Backport release-23.05] rapidcheck: Simplify installation, update, pkg-config #280330

merged 3 commits into from
Jan 12, 2024

Conversation

Ericson2314
Copy link
Member

Description of changes

Backport of #274925. Rapidcheck is only used by Nix, and this allows simplifying the build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Ericson2314
rapidcheck: Use stock installation, multiple outputs
63fa907 
We had neglected to nice `RC_INSTALL_ALL_EXTRAS`, which will take care
of installing the "extras" for us.

Now that they are in a standard directory, we don't need to smuggle in
the extra `-I` for Nix's tests either.

(cherry picked from commit ab8cf01)
(cherry picked from commit 0acb4d6)
@Ericson2314
rapidcheck: unstable-2023-04-16 -> unstable-2023-12-14
6bca544 
(cherry picked from commit 789df4b)
(cherry picked from commit bf66898)
@Ericson2314
rapidcheck: Add meta.pkgConfigModules and test
0af5360 
The last update added pkg-config support.

Co-authored-by: Robert Hensing <[email protected]>
(cherry picked from commit a7447f9)
(cherry picked from commit 96d3c84)
@Ericson2314 Ericson2314 merged commit a1982c9 into NixOS:release-23.05 Jan 12, 2024
23 checks passed
@Ericson2314 Ericson2314 deleted the rapidcheck-23.05 branch January 12, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artturin Artturin Awaiting requested review from Artturin

@edolstra edolstra Awaiting requested review from edolstra

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ericson2314