Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcard: enable auto-update #281267

Merged
merged 2 commits into from
Jun 20, 2024
Merged

vcard: enable auto-update #281267

merged 2 commits into from
Jun 20, 2024

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Jan 16, 2024

Description of changes

Should be self-explanatory. Tested with nix-shell maintainers/scripts/update.nix --argstr package vcard.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable: nix-update python3Packages.vcard updated the package
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sorry, something went wrong.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 16, 2024
@l0b0 l0b0 force-pushed the auto-update-vcard branch from 7b79949 to bdf67f3 Compare January 17, 2024 02:15
@l0b0 l0b0 force-pushed the auto-update-vcard branch from bdf67f3 to b12c23e Compare April 27, 2024 07:13
@l0b0 l0b0 marked this pull request as ready for review April 27, 2024 07:21
@l0b0 l0b0 requested a review from adisbladis April 27, 2024 08:26
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 22, 2024
@l0b0 l0b0 force-pushed the auto-update-vcard branch from b12c23e to 965018f Compare June 20, 2024 02:10
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 20, 2024
@jopejoe1 jopejoe1 merged commit 5e952b6 into NixOS:master Jun 20, 2024
25 checks passed
@l0b0 l0b0 deleted the auto-update-vcard branch June 20, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants