Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.ward: fix broken build #307318

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pkgs/development/python-modules/ward/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ buildPythonPackage rec {
owner = "darrenburns";
repo = "ward";
rev = "refs/tags/release%2F${version}";
hash = "sha256-4dEMEEPySezgw3dIcYMl56HrhyaYlql9JvtamOn7Y8g=";
hash = "sha256-Qc209wGrBk5rPWR6vS17w9aQyydU6U/8QBD85LbJWV0=";
};

build-system = [
Expand All @@ -36,7 +36,15 @@ buildPythonPackage rec {
rich
tomli
pprintpp
cucumber-tag-expressions
(cucumber-tag-expressions.overridePythonAttrs (_: rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't override version for modules. if possible the constraint of cucumber-tag-expressions could be relaxed.

Otherwise we have to wait for upstream: darrenburns/ward#380

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, thanks for opening an issue upstream! Could I try changing the version constraints in the derivation?

version = "4.1.0";
src = fetchFromGitHub{
owner = "cucumber";
repo = "tag-expressions";
rev = "refs/tags/v${version}";
hash = "sha256-tKvLOAHi6CMWOW4qNeLkxInqoG4KJjmj7YtFZf4Bmi4=";
};
}))
click-default-group
click-completion
pluggy
Expand Down