Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.colormath: refactor #313342

Merged
merged 2 commits into from
May 21, 2024
Merged

python312Packages.colormath: refactor #313342

merged 2 commits into from
May 21, 2024

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 21, 2024 •
edited
Loading

Description of changes

Part of #311054

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

fabaff added 2 commits May 21, 2024 10:30
@fabaff
python312Packages.colormath: refactor
7fb25ef 
- switch to pytestCheckHook
- update version
- update build-system
@fabaff
python312Packages.colormath: format with nixfmt
fc4e93e
@fabaff fabaff mentioned this pull request May 21, 2024
Closed
@fabaff
Copy link
Member Author

fabaff commented May 21, 2024

Result of nixpkgs-review pr 313342 run on x86_64-linux 1

8 packages built:
  • python311Packages.colormath
  • python311Packages.colormath.dist
  • python311Packages.sumo
  • python311Packages.sumo.dist
  • python312Packages.colormath
  • python312Packages.colormath.dist
  • python312Packages.sumo
  • python312Packages.sumo.dist

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 21, 2024
@ofborg ofborg bot requested a review from JonathanReeve May 21, 2024 09:16
@fabaff fabaff merged commit 10ddb3c into NixOS:master May 21, 2024
28 of 29 checks passed
@fabaff fabaff deleted the colormath-refactor branch May 21, 2024 10:08
JonathanReeve
JonathanReeve reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@JonathanReeve JonathanReeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanReeve JonathanReeve JonathanReeve left review comments

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabaff @JonathanReeve