Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.fipy: disable on Python 3.12+ and skip checkPhase #317324

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

ConnorBaker
Copy link
Contributor

@ConnorBaker ConnorBaker commented Jun 5, 2024

Description of changes

Mark as broken with Python 3.12 and disable checks.

Python 3.12 is an ongoing work (usnistgov/fipy#1023) upstream, and Hydra should not try to build it (https://hydra.nixos.org/build/262255462).

Checks fail (https://hydra.nixos.org/build/262253387), perhaps due to changes in indexing.

Failing doctests:

https://github.com/usnistgov/fipy/blob/fdc17193bc293da7511be9021e6d4766757e1966/fipy/matrices/scipyMatrix.py#L302-L306

Example test failures:

python3.11-fipy> ----------------------------------------------------------------------
python3.11-fipy> File "/build/source/fipy/matrices/scipyMatrix.py", line 302, in fipy.matrices.scipyMatrix._ScipyMatrix.CSR
python3.11-fipy> Failed example:
python3.11-fipy>     print(numerix.asarray(cols))
python3.11-fipy> Expected:
python3.11-fipy>     [0 1 2 1 2 0 2]
python3.11-fipy> Got:
python3.11-fipy>     [0 2 1 2 1 2 0]
python3.11-fipy> ----------------------------------------------------------------------
python3.11-fipy> File "/build/source/fipy/matrices/scipyMatrix.py", line 304, in fipy.matrices.scipyMatrix._ScipyMatrix.CSR
python3.11-fipy> Failed example:
python3.11-fipy>     print(numerix.asarray(data))
python3.11-fipy> Expected:
python3.11-fipy>     [ 12.3         10.           3.           3.14159265   2.96
python3.11-fipy>        2.5          2.2       ]
python3.11-fipy> Got:
python3.11-fipy>     [ 12.3          3.          10.           2.96         3.14159265
python3.11-fipy>        2.2          2.5       ]
python3.11-fipy> ----------------------------------------------------------------------

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ConnorBaker
Copy link
Contributor Author

ConnorBaker commented Jun 5, 2024

Result of nixpkgs-review pr 317324 run on aarch64-darwin 1

2 packages built:
  • python311Packages.fipy
  • python311Packages.fipy.dist

@ConnorBaker
Copy link
Contributor Author

ConnorBaker commented Jun 5, 2024

Result of nixpkgs-review pr 317324 run on x86_64-darwin 1

2 packages built:
  • python311Packages.fipy
  • python311Packages.fipy.dist

@ConnorBaker
Copy link
Contributor Author

Result of nixpkgs-review pr 317324 run on aarch64-linux 1

2 packages built:
  • python311Packages.fipy
  • python311Packages.fipy.dist

@ConnorBaker
Copy link
Contributor Author

Result of nixpkgs-review pr 317324 run on x86_64-linux 1

2 packages built:
  • python311Packages.fipy
  • python311Packages.fipy.dist

@wd15
Copy link
Contributor

wd15 commented Jun 14, 2024

Looks good to me.

Result of nixpkgs-review pr 317324 run on x86_64-linux 1

2 packages built:
  • python311Packages.fipy
  • python311Packages.fipy.dist

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jun 14, 2024
@onny onny merged commit d1cfa77 into NixOS:master Jun 15, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants