nixos/onlyoffice: don't drop database on start #319858
Conversation
If nextcloud is down, or the changes can otherwise not be saved back to nextcloud (e.g. because of [1]), the onlyoffice database contains _all the user data_ and should absolutely not be dropped on startup! [1]: ONLYOFFICE/onlyoffice-nextcloud#931
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
|
I think I copied that from the docker container script. I am not sure why and never questioned this. Also would you be interested in helping to maintain this? I think you where also in the thread recently together with @MarcelCoding and I am really needing some help here. |
|
As far as I can tell. It should be absolutely safe to keep the database. I've restored the database already multiple times because of data loss and it worked without issues all the time. The only problem I could think of is the absence of database migrations because upstream is dropping everything on startup. |
|
I want to follow upstream here because sadly everything else is a lost cause for onlyoffice and since their source code is not great to work with, we can't work around this. At this point we can't even compile the software from source... |
|
I've created an upstream issue: ONLYOFFICE/DocumentServer#2787 |
If nextcloud is down, or the changes can otherwise not be saved back to nextcloud (e.g. because of 1), the onlyoffice database contains all the user data and should absolutely not be dropped on startup!
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.