xen: 4.15 -> {4.16,4.17,4.18,4.19} #324693
Conversation
github-actions
bot
added
6.topic: nixos
NixOSInfra
added
the
12. first-time contribution
This comment was marked as outdated.
This comment was marked as outdated.
SigmaSquadron
force-pushed
the
xen-4.18
branch
2 times, most recently
from
8dbcbe0 to
80dcdc6
Compare
ofborg
bot
added
8.has: clean-up
8.has: package (new)
|
Fixed the unpatched binaries. Keep in mind XKCD 1513 as you review. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Would you be willing to cherry-pick the maintainers and Then we can try to merge bits and pieces of this so that only the gnarly stuff that I'm not comfortable with is left 😄 |
github-actions
bot
removed
the
6.topic: nixos
Sorry, I'm an upstream Xen developer, and can advise on that side of things, but I don't have time (or indeed the expertise) to advise on the NixOS side of things. |
That sounds like an over-reaction, the infra should have the tools needed, but it needs to b researched to figure out how to implement them else RFC
My apologies i confused you with nix developer and realized my mistake shortly after. |
Xen requires a bare-metal host to run. It's not a question of tooling, it's a question of not running tests inside containers/VMs, which isn't supported by Nixpkgs, and would require a tremendous amount of resources to effectively implement. |
Hopefully the final Result of 2 packages marked as broken and skipped:
45 packages built:
|
There was a problem hiding this comment.
As discussed in nixos devel chat and with nixos security team representative for the approach to get this implemented and maintained.
Refer to the linked discussion for usage notes in production/mission critical environment.
SigmaSquadron
added
12.approvals: 2
There are too many changes to list between these versions, but here's what's important for Nixpkgs: - Enabled xen.efi building, allowing the nixos/xen module to support EFI booting. - Renamed xen-light to xen-slim, and removed the old xen-slim package, as qemu-traditional has been removed per an upstream recommendation. - xen-slim (formerly xen-light) no longer builds iPXE. - You can now use the OVMF from Xen's repos. - Further generalised generic.nix. Maintaining three versions at once is finally doable. - Removed as many recursions as possible. - Split the package output. Signed-off-by: Fernando Rodrigues <[email protected]>
The update script is interactive, not automated, and is meant to run with human intervention in order to verify Xen's code signature. It produces default.nix files for all security-supported branches. Signed-off-by: Fernando Rodrigues <[email protected]>
xen-light was dropped in favour of xen and xen-slim Signed-off-by: Fernando Rodrigues <[email protected]> Reviewed-by: Matei Dibu <[email protected]>
In function 'libvchan__check_domain_alive': error: unknown type name 'xc_dominfo_t'; did you mean 'xc_meminfo_t'? error: implicit declaration of function 'xc_domain_getinfo'; did you mean 'xc_domain_getvnuma'? [-Werror=implicit-function-declaration] error: request for member 'domid' in something not a structure or union error: request for member 'dying' in something not a structure or union Signed-off-by: Fernando Rodrigues <[email protected]> Reviewed-by: Joachim Ernst <[email protected]>
In file included from ./driver/xen/xen_private.h:42, error: unknown type name 'xc_dominfo_t'; did you mean 'xc_meminfo_t'? PR NixOS#328873 reverts this commit and updates LibVMI. Signed-off-by: Fernando Rodrigues <[email protected]>
|
Congrats on this huge achievement! |
Description of changes
Required by #324911.
Things done
sandbox = truepkg-configtest passes successfully.nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"../result/bin/)Closes #320335, closes #26899.
Add a 👍 reaction to pull requests you find important.