Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pynose: drop due to licensing issues #325669

Merged
merged 46 commits into from
Jul 9, 2024

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jul 8, 2024

Description of changes

mdmintz/pynose#16
#311054

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@MostAwesomeDude
Copy link
Contributor

Thanks for this hard work! Offhand, I don't see any issues. However, there may be a bigger problem; in this Mastodon thread many folks are bringing together a lot of evidence that multiple Python packages uploaded by this maintainer are improperly licensed. I'm not sure where to take this next; perhaps it needs to come up in Discourse. While this PR should be merged when it's ready, we may need a more systemic response as well.

@mweinelt
Copy link
Member Author

mweinelt commented Jul 9, 2024

1807 rebuilds per target across 47 commits is not too bad.

@vcunat
Copy link
Member

vcunat commented Jul 9, 2024

For reference, this PR took a bit different approach:
#323410

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/error-nose-1-3-7-not-supported-for-interpreter-python3-12/48703/8

@dotlambda
Copy link
Member

For reference, this PR took a bit different approach: #323410

So do #325847 and #325865.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/distrusting-upstream-packages-from-mdmintz/48745/1

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the xlib commit: #325872

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/error-nose-1-3-7-not-supported-for-interpreter-python3-12/48703/12

It was apparently unused.
@mweinelt mweinelt merged commit 49a4992 into NixOS:master Jul 9, 2024
8 of 9 checks passed
@mweinelt mweinelt deleted the drop-pynose branch July 9, 2024 15:38
@dschrempf
Copy link
Contributor

FYI: The license of pynose has been adapted to LGPL-2: mdmintz/pynose@c3aa742.

@mweinelt
Copy link
Member Author

mweinelt commented Jul 9, 2024

Yeah, maybe. But the lost trust needs to be restored, before I'll consider allowing it back in. Right now #325935 looks more interesting to me.

@mightyiam
Copy link
Member

Thank you, @mweinelt

@dschrempf
Copy link
Contributor

Yes, I also want to thank you @mweinelt. This was a fast and professional cleansing.

@collares
Copy link
Member

One more "thank you @mweinelt" for the prompt response. The upstream response to the licensing issue is simply atrocious.

@pbsds pbsds mentioned this pull request Jul 10, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants