-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.pynose: drop due to licensing issues #325669
Conversation
Thanks for this hard work! Offhand, I don't see any issues. However, there may be a bigger problem; in this Mastodon thread many folks are bringing together a lot of evidence that multiple Python packages uploaded by this maintainer are improperly licensed. I'm not sure where to take this next; perhaps it needs to come up in Discourse. While this PR should be merged when it's ready, we may need a more systemic response as well. |
1807 rebuilds per target across 47 commits is not too bad. |
For reference, this PR took a bit different approach: |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/error-nose-1-3-7-not-supported-for-interpreter-python3-12/48703/8 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/distrusting-upstream-packages-from-mdmintz/48745/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the xlib commit: #325872
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/error-nose-1-3-7-not-supported-for-interpreter-python3-12/48703/12 |
It was apparently unused.
Co-Authored-By: Mauricio Collares <[email protected]>
The pynose package violates the license of nose, which is distributed under the LGPL license, by redistributing its code under the MIT license.
FYI: The license of |
Yeah, maybe. But the lost trust needs to be restored, before I'll consider allowing it back in. Right now #325935 looks more interesting to me. |
Thank you, @mweinelt |
Yes, I also want to thank you @mweinelt. This was a fast and professional cleansing. |
One more "thank you @mweinelt" for the prompt response. The upstream response to the licensing issue is simply atrocious. |
Description of changes
mdmintz/pynose#16
#311054
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.