-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paperwork: unbreak #327214
Merged
Merged
paperwork: unbreak #327214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilazy
reviewed
Jul 14, 2024
emilazy
reviewed
Jul 14, 2024
pyrox0
force-pushed
the
unbreak-paperwork
branch
from
July 14, 2024 22:21
12b2fbf
to
bc7e046
Compare
emilazy
approved these changes
Jul 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 327214
run on x86_64-darwin 1
4 packages built:
- python311Packages.fabulous
- python311Packages.fabulous.dist
- python312Packages.fabulous
- python312Packages.fabulous.dist
commit content seems fine at a glance, but commit messages should start with |
pyrox0
force-pushed
the
unbreak-paperwork
branch
from
July 14, 2024 23:03
bc7e046
to
a5a0fc8
Compare
Updated both commit messages |
…modernize and remove nose Updates to a recent commit that removes nose in favor of pytest. Also includes a few misc improvements made upstream.
pyrox0
force-pushed
the
unbreak-paperwork
branch
from
July 19, 2024 01:32
a5a0fc8
to
e9277a6
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: python
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As reported here,
paperwork
was broken due to bothpypillowfight
andfabulous
being broken. This fixes both of them, by:pypillowfight
to a recent commit that removes nose tests, allowing it to work on recent python versions. The tests also pass now, so there's no reason to havedoCheck = false;
now.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.