python3Packages.beaker: replace nose tests with pytest #327530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilazy
reviewed
Jul 16, 2024
Comment on lines
60
to
+64
| # Disable external tests because they need to connect to a live database. | ||
| # Also disable a test in test_cache.py called "test_upgrade" because | ||
| # it currently fails on darwin. | ||
| # Please see issue https://github.com/bbangert/beaker/issues/166 | ||
| checkPhase = '' | ||
| nosetests \ | ||
| -e ".*test_ext_.*" \ | ||
| -e "test_upgrade" \ | ||
| ${lib.optionalString (!stdenv.isLinux) ''-e "test_cookie_expires_different_locale"''} \ | ||
| -vv tests | ||
| ''; | ||
| pytestFlagsArray = [ | ||
| "--ignore=tests/test_memcached.py" | ||
| "--ignore-glob='tests/test_managers/test_ext_*'" | ||
| ]; |
There was a problem hiding this comment.
Can we use disabledTests here? Maybe not, because of the glob?
|
That's right, the glob requires the other flag.
…-------- Original Message --------
On 16/07/24 14:00, Emily wrote:
@emilazy commented on this pull request.
---------------------------------------------------------------
In [pkgs/development/python-modules/beaker/default.nix](#327530 (comment)):
> # Disable external tests because they need to connect to a live database.
- # Also disable a test in test_cache.py called "test_upgrade" because
- # it currently fails on darwin.
- # Please see issue bbangert/beaker#166
- checkPhase = ''
- nosetests \
- -e ".*test_ext_.*" \
- -e "test_upgrade" \
- ${lib.optionalString (!stdenv.isLinux) ''-e "test_cookie_expires_different_locale"''} \
- -vv tests
- '';
+ pytestFlagsArray = [
+ "--ignore=tests/test_memcached.py"
+ "--ignore-glob='tests/test_managers/test_ext_*'"
+ ];
Can we use disabledTests here? Maybe not, because of the glob?
—
Reply to this email directly, [view it on GitHub](#327530 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AZUKSCCUKSYQXGKY6NICHTLZMTK2BAVCNFSM6AAAAABK5WAZK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZZGU3TGNZZHE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
emilazy
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Addresses #326513.
Dependency nose was replaces by pytest in version 1.12.0 (2022-12-07).
checkPhasetopytestFlagsArray.pyproject = truePEP 517 migrationThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.