Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.{blackdiag,seqdiag,actdiag,nwdiag}: drop nose dependency #330396

Merged
merged 4 commits into from
Jul 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions pkgs/development/python-modules/actdiag/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
blockdiag,
buildPythonPackage,
fetchFromGitHub,
nose,
pytestCheckHook,
pythonOlder,
setuptools,
Expand All @@ -23,17 +22,13 @@ buildPythonPackage rec {
hash = "sha256-WmprkHOgvlsOIg8H77P7fzEqxGnj6xaL7Df7urRkg3o=";
};

patches = [ ./fix_test_generate.patch ];

build-system = [ setuptools ];

propagatedBuildInputs = [ blockdiag ];

# tests rely on nose
doCheck = pythonOlder "3.12";

nativeCheckInputs = [
nose
pytestCheckHook
];
nativeCheckInputs = [ pytestCheckHook ];

pytestFlagsArray = [ "src/actdiag/tests/" ];

Expand Down
22 changes: 22 additions & 0 deletions pkgs/development/python-modules/actdiag/fix_test_generate.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
diff --git a/src/actdiag/tests/test_generate_diagram.py b/src/actdiag/tests/test_generate_diagram.py
index c5ee3d5..a74a151 100644
--- a/src/actdiag/tests/test_generate_diagram.py
+++ b/src/actdiag/tests/test_generate_diagram.py
@@ -16,16 +16,6 @@
import os

from blockdiag.tests.test_generate_diagram import (get_diagram_files,
- testcase_generator)
+ test_generate_with_separate)

-import actdiag.command

-
-def test_generate():
- mainfunc = actdiag.command.main
- basepath = os.path.dirname(__file__)
- files = get_diagram_files(basepath)
- options = []
-
- for testcase in testcase_generator(basepath, mainfunc, files, options):
- yield testcase
19 changes: 14 additions & 5 deletions pkgs/development/python-modules/blockdiag/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
ephem,
fetchFromGitHub,
fetchpatch,
fetchpatch2,
funcparserlib,
pillow,
nose,
pytestCheckHook,
pythonOlder,
reportlab,
Expand Down Expand Up @@ -36,8 +36,21 @@ buildPythonPackage rec {
url = "https://github.com/blockdiag/blockdiag/commit/20d780cad84e7b010066cb55f848477957870165.patch";
hash = "sha256-t1zWFzAsLL2EUa0nD4Eui4Y5AhAZLRmp/yC9QpzzeUA=";
})
# https://github.com/blockdiag/blockdiag/pull/175
(fetchpatch2 {
name = "migrate-to-pytest.patch";
url = "https://github.com/blockdiag/blockdiag/commit/4f4f726252084f17ecc6c524592222af09d37da4.patch";
hash = "sha256-OkfKJwJtb2DJRXE/8thYnisTFwcfstUFTTJHdM/qBzg=";
})
];

postPatch = ''
# requires network access the url-based icon
# and path-based icon is set to debian logo (/usr/share/pixmaps/debian-logo.png)
rm src/blockdiag/tests/diagrams/node_icon.diag
Comment on lines +48 to +50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# note: this is a postPatch as `seqdiag` uses them directly
'';

build-system = [ setuptools ];

dependencies = [
Expand All @@ -48,12 +61,8 @@ buildPythonPackage rec {
webcolors
];

# tests rely on nose
doCheck = pythonOlder "3.12";

nativeCheckInputs = [
ephem
nose
pytestCheckHook
];

Expand Down
11 changes: 3 additions & 8 deletions pkgs/development/python-modules/nwdiag/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
blockdiag,
fetchFromGitHub,
buildPythonPackage,
nose,
pytestCheckHook,
setuptools,
pythonOlder,
Expand All @@ -23,17 +22,13 @@ buildPythonPackage rec {
hash = "sha256-uKrdkXpL5YBr953sRsHknYg+2/WwrZmyDf8BMA2+0tU=";
};

patches = [ ./fix_test_generate.patch ];

build-system = [ setuptools ];

dependencies = [ blockdiag ];

# tests rely on nose
doCheck = pythonOlder "3.12";

nativeCheckInputs = [
nose
pytestCheckHook
];
nativeCheckInputs = [ pytestCheckHook ];

pytestFlagsArray = [ "src/nwdiag/tests/" ];

Expand Down
22 changes: 22 additions & 0 deletions pkgs/development/python-modules/nwdiag/fix_test_generate.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
diff --git a/src/nwdiag/tests/test_generate_diagram.py b/src/nwdiag/tests/test_generate_diagram.py
index 2065208..ac9b096 100644
--- a/src/nwdiag/tests/test_generate_diagram.py
+++ b/src/nwdiag/tests/test_generate_diagram.py
@@ -16,16 +16,4 @@
import os

from blockdiag.tests.test_generate_diagram import (get_diagram_files,
- testcase_generator)
-
-import nwdiag.command
-
-
-def test_generate():
- mainfunc = nwdiag.command.main
- basepath = os.path.dirname(__file__)
- files = get_diagram_files(basepath)
- options = []
-
- for testcase in testcase_generator(basepath, mainfunc, files, options):
- yield testcase
+ test_generate_with_separate)
10 changes: 2 additions & 8 deletions pkgs/development/python-modules/seqdiag/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
blockdiag,
buildPythonPackage,
fetchFromGitHub,
nose,
pytestCheckHook,
pythonOlder,
setuptools,
Expand All @@ -27,14 +26,9 @@ buildPythonPackage rec {

dependencies = [ blockdiag ];

# tests rely on nose
doCheck = pythonOlder "3.12";

nativeCheckInputs = [
nose
pytestCheckHook
];
patches = [ ./fix_test_generate.patch ];

nativeCheckInputs = [ pytestCheckHook ];
pytestFlagsArray = [ "src/seqdiag/tests/" ];

pythonImportsCheck = [ "seqdiag" ];
Expand Down
25 changes: 25 additions & 0 deletions pkgs/development/python-modules/seqdiag/fix_test_generate.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
diff --git a/src/seqdiag/tests/test_generate_diagram.py b/src/seqdiag/tests/test_generate_diagram.py
index cdd340f..a1dd2d4 100644
--- a/src/seqdiag/tests/test_generate_diagram.py
+++ b/src/seqdiag/tests/test_generate_diagram.py
@@ -13,19 +13,5 @@
# See the License for the specific language governing permissions and
# limitations under the License.

-import os
-
from blockdiag.tests.test_generate_diagram import (get_diagram_files,
- testcase_generator)
-
-import seqdiag.command
-
-
-def test_generate():
- mainfunc = seqdiag.command.main
- basepath = os.path.dirname(__file__)
- files = get_diagram_files(basepath)
- options = []
-
- for testcase in testcase_generator(basepath, mainfunc, files, options):
- yield testcase
+ test_generate_with_separate)
Comment on lines +11 to +25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help me understand what this patch is doing? What’s the difference in behaviour here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testcase_generator was replaced with test_generate_with_separate with blackdiag migrate-to-pytest patch
Since it uses a pytest decoration (@pytest.mark.parametrize) it is collected automatically by pytest. All the logic is done through the single import statement