Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expresslrs-configurator: init at 1.7.2 #337022

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asamonik
Copy link
Contributor

@asamonik asamonik commented Aug 24, 2024

Description of changes

ExpressLRS Configurator is a cross-platform build & configuration tool for the ExpressLRS - open source RC link for RC applications.

When starting, electron complains about missing "devices" in app.asar. Maybe someone can guide me in the right direction to fix this :)

This is the error:

handling fatal error: Error: ENOENT, devices not found in /nix/store/rrb2ksvhh2dppdmp5f9zr59xhs8rmp94-expresslrs-configurator-1.7.2/share/expresslrs-configurator/app.asar

There is a devices folder in the resources folder of the electron app next to the app.asar:

 app-update.yml   app.asar   assets   devices   i18n   test

Closes #196193

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Aug 24, 2024
@asamonik asamonik marked this pull request as draft August 24, 2024 14:34
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Aug 24, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 24, 2024
@asamonik asamonik marked this pull request as ready for review September 9, 2024 08:38
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 16, 2024
@FliegendeWurst
Copy link
Member

Please squash with commit message like PR title.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 20, 2024
@asamonik asamonik force-pushed the expresslrs-configurator branch 2 times, most recently from 916fdc0 to 0ec6867 Compare November 20, 2024 11:08
autoPatchelfHook,
lib,
makeWrapper,
electron_27,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Electron 27 is marked as insecure. Is the program not compatible with newer versions?

Copy link
Contributor Author

@asamonik asamonik Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now upgraded to Electron 33 but it is throwing the same error with the missing devices folder. I am new to nix packaging and I am unsure how to investigate this error further. Thank you for your help!

@FliegendeWurst
Copy link
Member

handling fatal error: Error: ENOENT, devices not found in /nix/store/rrb2ksvhh2dppdmp5f9zr59xhs8rmp94-expresslrs-configurator-1.7.2/share/expresslrs-configurator/app.asar

I think you need to patch https://github.com/ExpressLRS/ExpressLRS-Configurator/blob/1408d1a7b573876a83fa989430d925fb90f39fe3/src/main/main.ts#L336 to point to the proper path in $out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExpressLRS Configurator
4 participants