-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expresslrs-configurator: init at 1.7.2 #337022
base: master
Are you sure you want to change the base?
Conversation
pkgs/applications/science/robotics/expresslrs-configurator/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/science/robotics/expresslrs-configurator/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/science/robotics/expresslrs-configurator/default.nix
Outdated
Show resolved
Hide resolved
Please squash with commit message like PR title. |
916fdc0
to
0ec6867
Compare
autoPatchelfHook, | ||
lib, | ||
makeWrapper, | ||
electron_27, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Electron 27 is marked as insecure. Is the program not compatible with newer versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now upgraded to Electron 33 but it is throwing the same error with the missing devices folder. I am new to nix packaging and I am unsure how to investigate this error further. Thank you for your help!
Signed-off-by: Andreas <[email protected]>
0ec6867
to
2aed8df
Compare
I think you need to patch https://github.com/ExpressLRS/ExpressLRS-Configurator/blob/1408d1a7b573876a83fa989430d925fb90f39fe3/src/main/main.ts#L336 to point to the proper path in $out. |
Description of changes
ExpressLRS Configurator is a cross-platform build & configuration tool for the ExpressLRS - open source RC link for RC applications.
When starting, electron complains about missing "devices" in app.asar. Maybe someone can guide me in the right direction to fix this :)
This is the error:
There is a devices folder in the resources folder of the electron app next to the app.asar:
Closes #196193
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.