-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide/nixos: remove with lib;
part 7
#337799
Open
Stunkymonkey
wants to merge
53
commits into
NixOS:master
Choose a base branch
from
Stunkymonkey:treewide-nixos-remove-with-lib-7
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
treewide/nixos: remove with lib;
part 7
#337799
Stunkymonkey
wants to merge
53
commits into
NixOS:master
from
Stunkymonkey:treewide-nixos-remove-with-lib-7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88aadd5
to
357d0f9
Compare
357d0f9
to
0acc2fb
Compare
9465227
to
08a4c88
Compare
67bfc9e
to
d2335fb
Compare
4700cf7
to
a570095
Compare
564418e
to
2752181
Compare
Stunkymonkey
commented
Dec 30, 2024
Comment on lines
-100
to
+104
defaultText = options.literalExpression "\${config.services.rss-bridge.dataDir}/cache/"; | ||
defaultText = lib.literalExpression "\${config.services.rss-bridge.dataDir}/cache/"; | ||
}; | ||
}; | ||
}; | ||
}; | ||
example = options.literalExpression '' | ||
example = lib.literalExpression '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these lines were done by hand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.status: merge conflict
This PR has merge conflicts with the target branch
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #208242
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.