Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.lockfile: Remove usage of nose; modernize #343765

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Sep 22, 2024

Description of changes

Part of #326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny, I was just working on this one :)

pkgs/development/python-modules/lockfile/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/lockfile/default.nix Outdated Show resolved Hide resolved
@emilazy
Copy link
Member

emilazy commented Sep 22, 2024

By the way, I’m not sure if pytest tries to run tests in parallel but if it does it should definitely be disabled for these cursed tests that mutate global state.

@pyrox0
Copy link
Member Author

pyrox0 commented Sep 22, 2024

By the way, I’m not sure if pytest tries to run tests in parallel but if it does it should definitely be disabled for these cursed tests that mutate global state.

Pytest only parallelizes with pytest-xdist installed, which is not the case here. Good catch though.

@emilazy
Copy link
Member

emilazy commented Sep 22, 2024

Result of nixpkgs-review pr 343765 run on aarch64-linux 1

4 packages failed to build:
  • python311Packages.ansible-kernel
  • python311Packages.ansible-kernel.dist
  • python311Packages.ansible-runner
  • python311Packages.ansible-runner.dist
82 packages built:
  • ansible-navigator
  • ansible-navigator.dist
  • deja-dup
  • duplicity
  • duplicity.dist
  • duply
  • esphome
  • esphome.dist
  • evdevremapkeys
  • evdevremapkeys.dist
  • hddfancontrol
  • hddfancontrol.dist
  • irrd
  • irrd.dist
  • keepkey-agent (python312Packages.keepkey-agent)
  • keepkey-agent.dist (python312Packages.keepkey-agent.dist)
  • ledger-agent (python312Packages.ledger-agent)
  • ledger-agent.dist (python312Packages.ledger-agent.dist)
  • luigi
  • luigi.dist
  • onlykey-agent
  • onlykey-agent.dist
  • platformio
  • platformio-core
  • platformio-core.dist
  • platformio-core.udev
  • pyrosimple
  • pyrosimple.dist
  • python311Packages.bugwarrior
  • python311Packages.bugwarrior.dist
  • python311Packages.keepkey-agent
  • python311Packages.keepkey-agent.dist
  • python311Packages.ledger-agent
  • python311Packages.ledger-agent.dist
  • python311Packages.libagent
  • python311Packages.libagent.dist
  • python311Packages.lockfile
  • python311Packages.lockfile.dist
  • python311Packages.mirakuru
  • python311Packages.mirakuru.dist
  • python311Packages.orange-canvas-core
  • python311Packages.orange-canvas-core.dist
  • python311Packages.orange-widget-base
  • python311Packages.orange-widget-base.dist
  • python311Packages.orange3
  • python311Packages.orange3.dist
  • python311Packages.pytest-postgresql
  • python311Packages.pytest-postgresql.dist
  • python311Packages.python-daemon
  • python311Packages.python-daemon.dist
  • python311Packages.python-fedora
  • python311Packages.python-fedora.dist
  • python311Packages.salmon-mail
  • python311Packages.salmon-mail.dist
  • python311Packages.trezor-agent
  • python311Packages.trezor-agent.dist
  • python312Packages.ansible-kernel
  • python312Packages.ansible-kernel.dist
  • python312Packages.ansible-runner
  • python312Packages.ansible-runner.dist
  • python312Packages.libagent
  • python312Packages.libagent.dist
  • python312Packages.lockfile
  • python312Packages.lockfile.dist
  • python312Packages.mirakuru
  • python312Packages.mirakuru.dist
  • python312Packages.orange-canvas-core
  • python312Packages.orange-canvas-core.dist
  • python312Packages.orange-widget-base
  • python312Packages.orange-widget-base.dist
  • python312Packages.orange3
  • python312Packages.orange3.dist
  • python312Packages.pytest-postgresql
  • python312Packages.pytest-postgresql.dist
  • python312Packages.python-daemon
  • python312Packages.python-daemon.dist
  • python312Packages.python-fedora
  • python312Packages.python-fedora.dist
  • python312Packages.salmon-mail
  • python312Packages.salmon-mail.dist
  • trezor-agent (python312Packages.trezor-agent)
  • trezor-agent.dist (python312Packages.trezor-agent.dist)

I’m baffled by the regression, but it seems real at first glance.

@pyrox0
Copy link
Member Author

pyrox0 commented Sep 22, 2024

The ansible-runner tests seem flaky, sometimes they work(seemingly more when they're run on their own) but sometimes they don't. I don't believe it's a problem with this package.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I’ll take your word for it :) I ran the build twice without success and they built fine on master, but it’s probably just luck of the draw. Merging, thank you!

@emilazy emilazy merged commit 5454b75 into NixOS:master Sep 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants