-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.lockfile: Remove usage of nose; modernize #343765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funny, I was just working on this one :)
By the way, I’m not sure if pytest tries to run tests in parallel but if it does it should definitely be disabled for these cursed tests that mutate global state. |
Pytest only parallelizes with |
5b180b0
to
16460de
Compare
Result of 4 packages failed to build:
82 packages built:
I’m baffled by the regression, but it seems real at first glance. |
The ansible-runner tests seem flaky, sometimes they work(seemingly more when they're run on their own) but sometimes they don't. I don't believe it's a problem with this package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I’ll take your word for it :) I ran the build twice without success and they built fine on master
, but it’s probably just luck of the draw. Merging, thank you!
Description of changes
Part of #326513
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.