Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.scales: use pytestCheckHook; modernize #348559

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Oct 14, 2024

This builds on the work done in #334466 as part of #326513. This fixes outstanding notes about migrating to pyproject and modernizes the rest of the Nix code. I cherry-picked the commit from the previous PR to ensure proper authorship notices are retained.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
Copy link
Member

emilazy commented Oct 14, 2024

Thanks! I was thinking we could probably just drop this as it’s only used as an optional dependency for one other package, but the end result of this PR looks good to me. I don’t suppose you’d be interested in being a maintainer for the package?

@pyrox0
Copy link
Member Author

pyrox0 commented Oct 14, 2024

Doesn't seem like too much of a maintainence burden, I'll adopt the package. If it becomes a hassle in the future, since I don't use it and it's only an optional dependency, we can definitely revisit dropping it.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Result of nixpkgs-review pr 348559 run on aarch64-linux 1

11 packages built:
  • cassandra
  • cassandra_3_0
  • cassandra_3_11
  • python311Packages.cassandra-driver
  • python311Packages.cassandra-driver.dist
  • python311Packages.scales
  • python311Packages.scales.dist
  • python312Packages.cassandra-driver
  • python312Packages.cassandra-driver.dist
  • python312Packages.scales
  • python312Packages.scales.dist

@emilazy emilazy merged commit 0f0d895 into NixOS:master Oct 14, 2024
10 of 11 checks passed
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants