python312Packages.{webassets, flask-assets}: remove nose; modernize #348621
Conversation
|
Currently running nixpkgs-review, will add output of that below once I've finished running it. |
|
Getting some build errors, trying to isolate the issue now. Edit: Fixed some |
|
Confirmed that the flask-mail test errors are unrelated to this PR. Pushing my dukpy changes, this is ready to review. |
webassets: use patch
pyrox0
force-pushed
the
denose/webassets
branch
from
c3c9358
to
3a2ef16
Compare
| postPatch = '' | ||
| substituteInPlace tests/test_webassets_filter.py \ | ||
| --replace-fail "class PyTestTemp" "class _Temp" \ | ||
| --replace-fail "PyTestTemp" "Temp" | ||
| ''; |
There was a problem hiding this comment.
Do you know what’s going on here? Was it broken already or do the changes in this PR somehow make this necessary?
There was a problem hiding this comment.
Ah, I see, it’s adapting for the changes in webassets.test. Okay, that seems fine then; hopefully upstream will release and the ecosystem will adapt at some point so that we no longer need to carry this.
There was a problem hiding this comment.
LGTM, thank you!
It’s a shame to have to carry a patch like this around but there’s not much we can do when upstream hasn’t properly finished the migration and it’s too widely depended upon to drop. (And anyway, that’s inherited from the previous PR.)
We’re almost at the finish line!
Result of nixpkgs-review pr 348621 run on aarch64-linux 1
1 package failed to build:
- powerdns-admin
14 packages built:
- pyload-ng
- pyload-ng.dist
- python311Packages.dukpy
- python311Packages.dukpy.dist
- python311Packages.flask-assets
- python311Packages.flask-assets.dist
- python311Packages.webassets
- python311Packages.webassets.dist
- python312Packages.dukpy
- python312Packages.dukpy.dist
- python312Packages.flask-assets
- python312Packages.flask-assets.dist
- python312Packages.webassets
- python312Packages.webassets.dist
| postPatch = '' | ||
| substituteInPlace tests/test_webassets_filter.py \ | ||
| --replace-fail "class PyTestTemp" "class _Temp" \ | ||
| --replace-fail "PyTestTemp" "Temp" | ||
| ''; |
There was a problem hiding this comment.
Ah, I see, it’s adapting for the changes in webassets.test. Okay, that seems fine then; hopefully upstream will release and the ecosystem will adapt at some point so that we no longer need to carry this.
Follows up and includes the work from #334483. Fixes some broken subsitutions in
flask-assetsand enables some tests inwebassets.Part of #326513.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.