Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.fabric: add pynacl as dependency #350059

Closed
wants to merge 5 commits into from

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Oct 20, 2024

Fixes the build failure that appeared in https://hydra.nixos.org/build/274289142

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@getchoo getchoo added 0.kind: build failure A package fails to build 0.kind: package adoption Requests or PRs for adopting packages that have no maintainers labels Oct 20, 2024
@getchoo
Copy link
Member Author

getchoo commented Oct 20, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350059


aarch64-linux

❌ 2 packages failed to build:
  • azure-cli
  • azure-cli.dist
✅ 8 packages built:
  • Fabric (python312Packages.fabric)
  • linien-gui
  • linien-gui.dist
  • python311Packages.fabric
  • python311Packages.linien-client
  • python311Packages.linien-client.dist
  • python312Packages.linien-client
  • python312Packages.linien-client.dist

`azure-cli` fails with the following. Doesn't seem to be caused by this PR
error: builder for '/nix/store/i6h7pjv2a6smaal3ppja1jnzcg1451ya-python3.12-azure-cli-core-2.64.0.drv' failed with exit code 2;
       last 10 log lines:
       >
       > azure/cli/core/tests/test_help_loaders.py:13
       >   /build/azure-cli-2.64.0-src/src/azure-cli-core/azure/cli/core/tests/test_help_loaders.py:13: PytestCollectionWarning: cannot collect test class 'TestCommandLoader' because it has a __init__ constructor (from: azure/cli/core/tests/test_help_loaders.py)
       >     class TestCommandLoader(AzCommandsLoader):
       >
       > -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
       > =========================== short test summary info ============================
       > ERROR azure/cli/core/tests/test_keys.py
       > !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
       > ================== 2 deselected, 2 warnings, 1 error in 1.98s ==================
       For full logs, run 'nix log /nix/store/i6h7pjv2a6smaal3ppja1jnzcg1451ya-python3.12-azure-cli-core-2.64.0.drv'.
error: 1 dependencies of derivation '/nix/store/2hkyc8vg4dyfnkvawjllyiw1sksm57lm-python3.12-azure-cli-2.64.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/ga7pkkj44lx3miljxcmpd9rgg40vgz3z-review-shell.drv' failed to build

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 20, 2024
Copy link
Contributor

@DerDennisOP DerDennisOP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 21, 2024
@katexochen
Copy link
Contributor

Build failure is in paramiko, see #348995. Fix is already in staging-next.

@getchoo
Copy link
Member Author

getchoo commented Oct 23, 2024

Ah, thanks!

@getchoo getchoo closed this Oct 23, 2024
@getchoo getchoo deleted the pkgs/fabric/nacl branch October 23, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build 0.kind: package adoption Requests or PRs for adopting packages that have no maintainers 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants