Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/send: init #351255

Merged
merged 1 commit into from
Oct 28, 2024
Merged

nixos/send: init #351255

merged 1 commit into from
Oct 28, 2024

Conversation

Moraxyc
Copy link
Contributor

@Moraxyc Moraxyc commented Oct 25, 2024 •
edited
Loading

  • nixos/send: init

must be merged after #350931

Closes #350025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 25, 2024
@Moraxyc Moraxyc force-pushed the add-node-send-module branch 2 times, most recently from 4365740 to 7f666d6 Compare October 25, 2024 19:26
@Moraxyc
Copy link
Contributor Author

Moraxyc commented Oct 25, 2024

@74k1 please test this module

@Moraxyc
Copy link
Contributor Author

Moraxyc commented Oct 25, 2024

@ofborg test send

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Oct 25, 2024
@Moraxyc Moraxyc requested a review from drupol October 26, 2024 01:49
drupol
drupol requested changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Just made a quick review.

nixos/modules/services/web-servers/send.nix Outdated Show resolved Hide resolved
pkgs/by-name/se/send/package.nix Outdated Show resolved Hide resolved
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Oct 26, 2024
@Moraxyc Moraxyc requested a review from drupol October 26, 2024 15:23
@NiklasGollenstede
Copy link
Contributor

Can't say I had heard about this send before, but the module looks nice!

systemd hardening, DynamicUser, systemd-credentials, not inherently any secrets in the store 👍

Is just "send" an appropriate package name, tough? Do other distributions also simply call it "send"?

@drupol
Copy link
Contributor

drupol commented Oct 27, 2024

Can you rebase this PR now that #350931 has been merged?

@Moraxyc
Copy link
Contributor Author

Moraxyc commented Oct 27, 2024

Can't say I had heard about this send before, but the module looks nice!

systemd hardening, DynamicUser, systemd-credentials, not inherently any secrets in the store 👍

Is just "send" an appropriate package name, tough? Do other distributions also simply call it "send"?

I have searched the entire nixpkgs and found no conflicting modules or package names.
I agree with you that Send sounds a bit too common, but it is indeed the name upstream

@Moraxyc
Copy link
Contributor Author

Moraxyc commented Oct 27, 2024

Can you rebase this PR now that #350931 has been merged?

Done.

@Moraxyc Moraxyc added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 27, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Oct 27, 2024
@74k1

This comment was marked as off-topic.

Sign in to view
@drupol drupol merged commit dc8a253 into NixOS:master Oct 28, 2024
27 checks passed
@Moraxyc Moraxyc deleted the add-node-send-module branch October 28, 2024 17:27
dotlambda
dotlambda reviewed Oct 29, 2024
View reviewed changes
nixos/modules/services/web-servers/send.nix
(listOf int)
])
);
description = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = ''
default = { };
description = ''

nixos/modules/services/web-servers/send.nix
services.redis = lib.optionalAttrs cfg.redis.createLocally {
servers."${cfg.redis.name}" = {
enable = true;
bind = "localhost";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a Unix socket by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: NixOS module send
6 participants
@Moraxyc @NiklasGollenstede @drupol @74k1 @dotlambda @h7x4