-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitwarden-desktop: add aarch64-linux support #351355
bitwarden-desktop: add aarch64-linux support #351355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please make sure your commit message follows CONTRIBUTING.md
547d8d5
to
02861d7
Compare
hold up going to squash those two commits together |
516e09a
to
9c28d1f
Compare
squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I don’t have aarch64 platform available so cannot easily test.
Please also update the PR title to match the commit message format, and then one other small comment.
9c28d1f
to
5f4a216
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. One thing I’ll note is that upstream doesn’t, afaik, officially support aarch64-linux (and I don’t have a dev env for it either), so support for the platform here will likely be limited.
5f4a216
to
1dd2806
Compare
I added aarch64-linux for bitwarden's desktop client. I've tested it and it works without issue. The only changes required relate to two directory names that are platform dependent.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.