Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zincsearch: 0.4.10 -> 0.4.10-unstable-2024-10-25, unbreak #351371

Merged
merged 2 commits into from
Oct 26, 2024
Merged

zincsearch: 0.4.10 -> 0.4.10-unstable-2024-10-25, unbreak #351371

merged 2 commits into from
Oct 26, 2024

Conversation

katexochen
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from dit7ya October 26, 2024 09:12
@katexochen katexochen requested a review from afh October 26, 2024 10:32
@afh
Copy link
Member

afh commented Oct 26, 2024

Result of nixpkgs-review pr 351371 run on aarch64-darwin 1

1 package built:
  • zincsearch

@afh
Copy link
Member

afh commented Oct 26, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351371

x86_64-linux

✅ 1 package built:
  • zincsearch

afh
afh approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @katexochen 🙂👍

@katexochen katexochen merged commit 00c97c7 into NixOS:master Oct 26, 2024
27 of 28 checks passed
@katexochen katexochen deleted the zincsearch/unst branch October 26, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afh afh afh approved these changes

@dit7ya dit7ya Awaiting requested review from dit7ya

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katexochen @afh