Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsstail: 2.1 -> 2.2 and libiconv darwin fix #351414

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Oct 26, 2024

update build and fix darwin linking with libiconv

https://hydra.nixos.org/build/276113446

folkertvanheusden/rsstail@6f24361...v2.2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 26, 2024
@emilazy
Copy link
Member

emilazy commented Oct 26, 2024

(Was in the middle of reviewing this and ran into folkertvanheusden/rsstail#7; will follow up later.)

@paparodeo paparodeo changed the title rsstail: link with libiconv on darwin rsstail: 2.1 -> 2.2 and libiconv darwin fix Oct 26, 2024
@emilazy emilazy merged commit eed6895 into NixOS:staging-next Oct 26, 2024
8 of 11 checks passed
@paparodeo paparodeo deleted the rsstail-liconv branch October 26, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants