Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bencodetools,uade: Fix build, update, modernise #352867

Merged
merged 10 commits into from
Nov 16, 2024

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Nov 1, 2024

Addresses the bencodetools build failure on Hydra, which started after Python got bumped to 3.11 (https://hydra.nixos.org/build/275774889) + general maintenance & update stuff.

  • bencodetools
    • Drop the python module building from the main package, which gets rid of the error
    • nixfmt it
    • Update src.hash format, get rid of meta-wide with lib
    • Update to latest stable version, add passthru.updateScript
    • Migrate it to pkgs/by-name
    • Re-init the python module as a separate python3Packages entry, inheriting lots of details from the main bencodetools package but only building the python module
  • libzakalwe
    • init (needed for newer uade)
  • uade
    • Drop the python tools building. It was already disabled on Darwin due to them not working there, but now that python doesn't like python setup.py install anymore, it just doesn't install anymore.
    • nixfmt it
    • Modernise
      • rec -> finalAttrs
      • --replace -> --replace-fail
      • Use lib.strings.withFeature
      • Get rid of meta-wide with lib
    • Update to latest stable version, add passthru.updateScript
    • Migrate it to pkgs/by-name

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium November 1, 2024 13:11
@OPNA2608 OPNA2608 changed the title bencodetools: Fix build, update, modernise bencodetools,uade: Fix build, update, modernise Nov 1, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 1, 2024
@OPNA2608 OPNA2608 force-pushed the fix/bencodetools branch 2 times, most recently from 01113d2 to acb5554 Compare November 4, 2024 15:48
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 11, 2024
@OPNA2608 OPNA2608 merged commit 2f3db1d into NixOS:master Nov 16, 2024
27 of 28 checks passed
@OPNA2608 OPNA2608 added the backport release-24.11 Backport PR automatically label Nov 24, 2024
Copy link
Contributor

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants