-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bencodetools,uade: Fix build, update, modernise #352867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPNA2608
changed the title
bencodetools: Fix build, update, modernise
bencodetools,uade: Fix build, update, modernise
Nov 1, 2024
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Nov 1, 2024
OPNA2608
force-pushed
the
fix/bencodetools
branch
2 times, most recently
from
November 4, 2024 15:48
01113d2
to
acb5554
Compare
wegank
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Nov 10, 2024
Newest python makes "setup.py install" not work anymore. This is likely better handled by making this a proper pythonPackages entry anyway.
Newest python makes "setup.py install" not work anymore.
OPNA2608
force-pushed
the
fix/bencodetools
branch
from
November 11, 2024 11:42
acb5554
to
35a5b60
Compare
ofborg
bot
removed
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Nov 11, 2024
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: python
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
backport release-24.11
Backport PR automatically
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the
bencodetools
build failure on Hydra, which started after Python got bumped to 3.11 (https://hydra.nixos.org/build/275774889) + general maintenance & update stuff.bencodetools
nixfmt
itsrc.hash
format, get rid ofmeta
-widewith lib
passthru.updateScript
pkgs/by-name
python3Packages
entry, inheriting lots of details from the mainbencodetools
package but only building the python modulelibzakalwe
uade
)uade
python setup.py install
anymore, it just doesn't install anymore.nixfmt
itrec
->finalAttrs
--replace
->--replace-fail
lib.strings.withFeature
meta
-widewith lib
passthru.updateScript
pkgs/by-name
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.